Fix bg color of bookmark bubble view

Fix bg color of bookmark bubble view

and make the bg color of all bubbles match the dialog bg color

BUG=376832
Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=274368

[Evan Stade, 2014-05-30 19:54:03]

wfm with high contrast inverse, ambiance, or Chrome theme

[Elliot Glaysher, 2014-05-30 20:04:31]

I patched this in locally. Can confirm that this works in both gtk mode and
chrome theme mode with both HCI and Ambiance.

lgtm

[msw, 2014-05-30 20:09:56]

This makes the whole bubble white, not the intended gray.

[Evan Stade, 2014-05-30 20:53:19]

On 2014/05/30 20:09:56, msw wrote:
> This makes the whole bubble white, not the intended gray.

a) on my monitor the difference is imperceptible
b) why is the bookmark bubble supposed to be a different color than all other
bubbles? To my recollection, it has always been ~white.

[msw, 2014-05-30 21:00:51]

On 2014/05/30 20:53:19, Evan Stade wrote:
> On 2014/05/30 20:09:56, msw wrote:
> > This makes the whole bubble white, not the intended gray.
> 
> a) on my monitor the difference is imperceptible
> b) why is the bookmark bubble supposed to be a different color than all other
> bubbles? To my recollection, it has always been ~white.

See http://crbug.com/231694 I believe the intent is to make all bubbles use the
dialog background color in the long term, it just hasn't had attention. Feel
free to ping Sebastien.

[Evan Stade, 2014-05-30 22:39:58]

On 2014/05/30 21:00:51, msw wrote:
> On 2014/05/30 20:53:19, Evan Stade wrote:
> > On 2014/05/30 20:09:56, msw wrote:
> > > This makes the whole bubble white, not the intended gray.
> > 
> > a) on my monitor the difference is imperceptible
> > b) why is the bookmark bubble supposed to be a different color than all
other
> > bubbles? To my recollection, it has always been ~white.
> 
> See http://crbug.com/231694 I believe the intent is to make all bubbles use
the
> dialog background color in the long term, it just hasn't had attention. Feel
> free to ping Sebastien.

sgabriel says all bubbles should have the dialog bg color (#fbfbfb) rather than
white, so I've made that change as well.

[msw, 2014-05-30 23:01:26]

Very nice; LGTM!

[Elliot Glaysher, 2014-05-30 23:10:00]

(slgtm)

[Evan Stade, 2014-05-30 23:17:36]

The CQ bit was checked by estade@chromium.org

[commit-bot: I haz the power, 2014-05-30 23:24:38]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/estade@chromium.org/309713002/10001

[commit-bot: I haz the power, 2014-05-31 05:20:14]

FYI, CQ is re-trying this CL (attempt #1).
The failing builders are:
  android_dbg_triggered_tests on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/android_dbg_triggered...)
  win_chromium_rel on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/win_chromium_rel/buil...)

[commit-bot: I haz the power, 2014-05-31 07:13:06]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-05-31 07:13:06]

Try jobs failed on following builders:
  win_chromium_rel on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/win_chromium_rel/buil...)

[Evan Stade, 2014-06-02 17:53:56]

The CQ bit was checked by estade@chromium.org

[commit-bot: I haz the power, 2014-06-02 17:54:37]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/estade@chromium.org/309713002/10001

[commit-bot: I haz the power, 2014-06-02 23:41:32]

Change committed as 274368