Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(130)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 309683002: Move GrIPoint16 to SkIPoint16 (and remove GrPoint.h) (Closed)

Created:
6 years, 6 months ago by robertphillips
Modified:
6 years, 6 months ago
Reviewers:
bsalomon, reed1
CC:
skia-review_googlegroups.com
Base URL:
https://skia.googlesource.com/skia.git@master
Visibility:
Public.

Description

Move GrIPoint16 to SkIPoint16 (and remove GrPoint.h) Committed: https://skia.googlesource.com/skia/+/d537341e16524d1e22ac5e6c8b9c8f274ba1833c

Patch Set 1 #

Patch Set 2 : cleanup #

Total comments: 1

Patch Set 3 : Switch from intptr_t to int #

Patch Set 4 : Update to ToT #

Unified diffs Side-by-side diffs Delta from patch set Stats (+48 lines, -67 lines) Patch
M gyp/gpu.gypi View 1 chunk +0 lines, -1 line 0 comments Download
M gyp/public_headers.gypi View 1 chunk +0 lines, -1 line 0 comments Download
M include/core/SkPoint.h View 1 2 1 chunk +22 lines, -0 lines 0 comments Download
M include/gpu/GrContext.h View 1 2 3 1 chunk +0 lines, -1 line 0 comments Download
M include/gpu/GrGlyph.h View 1 chunk +1 line, -1 line 0 comments Download
D include/gpu/GrPoint.h View 1 2 3 1 chunk +0 lines, -36 lines 0 comments Download
M samplecode/SampleRectanizer.cpp View 1 2 3 2 chunks +2 lines, -2 lines 0 comments Download
M src/gpu/GrAtlas.h View 4 chunks +4 lines, -4 lines 0 comments Download
M src/gpu/GrAtlas.cpp View 1 2 3 2 chunks +3 lines, -3 lines 0 comments Download
M src/gpu/GrDrawState.h View 1 chunk +0 lines, -1 line 0 comments Download
M src/gpu/GrInOrderDrawBuffer.cpp View 1 chunk +0 lines, -1 line 0 comments Download
M src/gpu/GrPathUtils.h View 1 chunk +0 lines, -1 line 0 comments Download
M src/gpu/GrPathUtils.cpp View 1 chunk +1 line, -1 line 0 comments Download
M src/gpu/GrPlotMgr.h View 3 chunks +2 lines, -3 lines 0 comments Download
M src/gpu/GrRectanizer.h View 1 2 3 2 chunks +4 lines, -2 lines 0 comments Download
M src/gpu/GrRectanizer_pow2.h View 1 2 3 3 chunks +3 lines, -2 lines 0 comments Download
M src/gpu/GrRectanizer_pow2.cpp View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
M src/gpu/GrRectanizer_skyline.h View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
M src/gpu/GrRectanizer_skyline.cpp View 1 chunk +2 lines, -1 line 0 comments Download
M src/gpu/GrTextContext.h View 1 chunk +0 lines, -1 line 0 comments Download
M src/gpu/GrTextStrike.h View 1 chunk +0 lines, -1 line 0 comments Download
M tests/GpuRectanizerTest.cpp View 2 chunks +2 lines, -2 lines 0 comments Download

Messages

Total messages: 6 (0 generated)
robertphillips
6 years, 6 months ago (2014-05-30 17:39:16 UTC) #1
reed1
SkPoint.h lgtm https://codereview.chromium.org/309683002/diff/10001/include/core/SkPoint.h File include/core/SkPoint.h (right): https://codereview.chromium.org/309683002/diff/10001/include/core/SkPoint.h#newcode30 include/core/SkPoint.h:30: void set(intptr_t x, intptr_t y) { I ...
6 years, 6 months ago (2014-05-30 17:41:21 UTC) #2
bsalomon
On 2014/05/30 17:39:16, robertphillips wrote: lgtm
6 years, 6 months ago (2014-05-30 17:50:06 UTC) #3
robertphillips
The CQ bit was checked by robertphillips@google.com
6 years, 6 months ago (2014-06-02 17:14:03 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://skia-tree-status.appspot.com/cq/robertphillips@google.com/309683002/40001
6 years, 6 months ago (2014-06-02 17:14:27 UTC) #5
commit-bot: I haz the power
6 years, 6 months ago (2014-06-02 17:20:19 UTC) #6
Message was sent while issue was closed. 
Change committed as d537341e16524d1e22ac5e6c8b9c8f274ba1833c

Powered by Google App Engine
This is Rietveld 408576698