Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(187)

Issue 309673002: Note that, when resource load aborts, loadstop fires after loadabort (Closed)

Created:
6 years, 6 months ago by Mark Dittmer
Modified:
6 years, 6 months ago
CC:
chromium-reviews, chromium-apps-reviews_chromium.org, extensions-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Visibility:
Public.

Description

Note that, when resource load aborts, loadstop fires after loadabort Whenever a resource load is aborted, two events fire: loadabort and loadstop. This change explicitly mentions two-event behaviour in our documentation of loadabort and loadstop events. Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=274280

Patch Set 1 #

Total comments: 1

Patch Set 2 : Add punctuation to documentation #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -3 lines) Patch
M chrome/common/extensions/api/webview_tag.json View 1 3 chunks +2 lines, -3 lines 0 comments Download

Messages

Total messages: 12 (0 generated)
Mark Dittmer
6 years, 6 months ago (2014-05-30 16:29:21 UTC) #1
fsamuel
lgtm https://codereview.chromium.org/309673002/diff/1/chrome/common/extensions/api/webview_tag.json File chrome/common/extensions/api/webview_tag.json (right): https://codereview.chromium.org/309673002/diff/1/chrome/common/extensions/api/webview_tag.json#newcode648 chrome/common/extensions/api/webview_tag.json:648: "description": "Fired when a top-level load has aborted ...
6 years, 6 months ago (2014-05-30 16:42:51 UTC) #2
Mark Dittmer
The CQ bit was checked by markdittmer@chromium.org
6 years, 6 months ago (2014-05-30 18:13:30 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/markdittmer@chromium.org/309673002/20001
6 years, 6 months ago (2014-05-30 18:16:16 UTC) #4
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: android_dbg_triggered_tests on tryserver.chromium ...
6 years, 6 months ago (2014-05-30 23:20:38 UTC) #5
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 6 months ago (2014-05-30 23:35:29 UTC) #6
commit-bot: I haz the power
Try jobs failed on following builders: chromium_presubmit on tryserver.chromium (http://build.chromium.org/p/tryserver.chromium/builders/chromium_presubmit/builds/70803)
6 years, 6 months ago (2014-05-30 23:35:32 UTC) #7
Mark Dittmer
Hey Ben, I'm Fady's intern this summer. I need an owner code review for this ...
6 years, 6 months ago (2014-06-02 13:59:50 UTC) #8
not at google - send to devlin
lgtm
6 years, 6 months ago (2014-06-02 16:44:30 UTC) #9
Mark Dittmer
The CQ bit was checked by markdittmer@chromium.org
6 years, 6 months ago (2014-06-02 17:59:59 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/markdittmer@chromium.org/309673002/20001
6 years, 6 months ago (2014-06-02 18:01:15 UTC) #11
commit-bot: I haz the power
6 years, 6 months ago (2014-06-02 18:07:12 UTC) #12
Message was sent while issue was closed.
Change committed as 274280

Powered by Google App Engine
This is Rietveld 408576698