Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(157)

Unified Diff: test/cctest/test-ordered-hash-table.cc

Issue 309663005: Split Put into Put and Remove (Closed) Base URL: http://v8.googlecode.com/svn/branches/bleeding_edge
Patch Set: Add assert and some comments Created 6 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « test/cctest/test-dictionary.cc ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: test/cctest/test-ordered-hash-table.cc
diff --git a/test/cctest/test-ordered-hash-table.cc b/test/cctest/test-ordered-hash-table.cc
index 1614e4b27e208afdbc5fdfe923f853852c7cf610..601fb1f1e772f0cbc8a0a05656062e6c8cb209b4 100644
--- a/test/cctest/test-ordered-hash-table.cc
+++ b/test/cctest/test-ordered-hash-table.cc
@@ -176,8 +176,9 @@ TEST(Map) {
ordered_map = OrderedHashMap::Put(ordered_map, obj, val);
CHECK_EQ(1, ordered_map->NumberOfElements());
CHECK(ordered_map->Lookup(obj)->SameValue(*val));
- ordered_map = OrderedHashMap::Put(
- ordered_map, obj, factory->the_hole_value());
+ bool was_present = false;
+ ordered_map = OrderedHashMap::Remove(ordered_map, obj, &was_present);
+ CHECK(was_present);
CHECK_EQ(0, ordered_map->NumberOfElements());
CHECK(ordered_map->Lookup(obj)->IsTheHole());
@@ -238,14 +239,14 @@ TEST(Map) {
true);
// Test shrinking
- ordered_map = OrderedHashMap::Put(
- ordered_map, obj, factory->the_hole_value());
- ordered_map = OrderedHashMap::Put(
- ordered_map, obj1, factory->the_hole_value());
- ordered_map = OrderedHashMap::Put(
- ordered_map, obj2, factory->the_hole_value());
- ordered_map = OrderedHashMap::Put(
- ordered_map, obj3, factory->the_hole_value());
+ ordered_map = OrderedHashMap::Remove(ordered_map, obj, &was_present);
+ CHECK(was_present);
+ ordered_map = OrderedHashMap::Remove(ordered_map, obj1, &was_present);
+ CHECK(was_present);
+ ordered_map = OrderedHashMap::Remove(ordered_map, obj2, &was_present);
+ CHECK(was_present);
+ ordered_map = OrderedHashMap::Remove(ordered_map, obj3, &was_present);
+ CHECK(was_present);
CHECK_EQ(1, ordered_map->NumberOfElements());
CHECK_EQ(2, ordered_map->NumberOfBuckets());
}
« no previous file with comments | « test/cctest/test-dictionary.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698