test/cctest/test-dictionary.cc - Issue 309663005: Split Put into Put and Remove

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: test/cctest/test-dictionary.cc

Issue 309663005: Split Put into Put and Remove (Closed) Base URL: http://v8.googlecode.com/svn/branches/bleeding_edge

Patch Set: Remove move without was_present and use that in the runtime for extra speed Created 6 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: test/cctest/test-dictionary.cc

diff --git a/test/cctest/test-dictionary.cc b/test/cctest/test-dictionary.cc

index fc2227f349beacee0853d0e283d6b8404d706e55..776783b4c2376f12eb28ea648f07883116aeb080 100644

--- a/test/cctest/test-dictionary.cc

+++ b/test/cctest/test-dictionary.cc

@@ -64,8 +64,9 @@ static void TestHashMap(Handle<HashMap> table) {

CHECK_EQ(table->NumberOfElements(), 1);

CHECK_NE(table->Lookup(a), *b);

Michael Starzinger 2014/06/02 13:34:04 nit: Let's add a comment along the lines of ... /

arv (Not doing code reviews) 2014/06/02 23:49:08 Done.

- // Keys mapped to the hole should be removed permanently.

- table = HashMap::Put(table, a, factory->the_hole_value());

+ bool was_present = false;

+ table = HashMap::Remove(table, a, &was_present);

+ CHECK(was_present);

CHECK_EQ(table->NumberOfElements(), 0);

CHECK_EQ(table->Lookup(a), CcTest::heap()->the_hole_value());