Split Put into Put and Remove

test/cctest/test-ordered-hash-table.cc

 // Copyright 2014 the V8 project authors. All rights reserved.
 // Redistribution and use in source and binary forms, with or without
 // modification, are permitted provided that the following conditions are
 // met:
 //
 //     * Redistributions of source code must retain the above copyright
 //       notice, this list of conditions and the following disclaimer.
 //     * Redistributions in binary form must reproduce the above
 //       copyright notice, this list of conditions and the following
 //       disclaimer in the documentation and/or other materials provided
@@ skipping 158 matching lines @@
   Handle<JSMapIterator> key_iterator =
       JSMapIterator::Create(ordered_map, JSMapIterator::kKindKeys);
 
   Handle<Map> map = factory->NewMap(JS_OBJECT_TYPE, JSObject::kHeaderSize);
   Handle<JSObject> obj = factory->NewJSObjectFromMap(map);
   Handle<JSObject> val = factory->NewJSObjectFromMap(map);
   CHECK(ordered_map->Lookup(obj)->IsTheHole());
   ordered_map = OrderedHashMap::Put(ordered_map, obj, val);
   CHECK_EQ(1, ordered_map->NumberOfElements());
   CHECK(ordered_map->Lookup(obj)->SameValue(*val));
-  ordered_map = OrderedHashMap::Put(
-      ordered_map, obj, factory->the_hole_value());
+  ordered_map = OrderedHashMap::Remove(ordered_map, obj);

[adamk, 2014/05/30 20:13:58]

Probably want to test the was_present version as well...

[arv (Not doing code reviews), 2014/05/30 20:53:07]

Done.

   CHECK_EQ(0, ordered_map->NumberOfElements());
   CHECK(ordered_map->Lookup(obj)->IsTheHole());
 
   // Test for collisions/chaining
   Handle<JSObject> obj1 = factory->NewJSObjectFromMap(map);
   Handle<JSObject> obj2 = factory->NewJSObjectFromMap(map);
   Handle<JSObject> obj3 = factory->NewJSObjectFromMap(map);
   Handle<JSObject> val1 = factory->NewJSObjectFromMap(map);
   Handle<JSObject> val2 = factory->NewJSObjectFromMap(map);
   Handle<JSObject> val3 = factory->NewJSObjectFromMap(map);
@@ skipping 40 matching lines @@
   CheckIterResultObject(
       isolate, JSMapIterator::Next(key_iterator), obj, false);
   CheckIterResultObject(
       isolate, JSMapIterator::Next(key_iterator), obj4, false);
   CheckIterResultObject(isolate,
                         JSMapIterator::Next(key_iterator),
                         factory->undefined_value(),
                         true);
 
   // Test shrinking
-  ordered_map = OrderedHashMap::Put(
-      ordered_map, obj, factory->the_hole_value());
-  ordered_map = OrderedHashMap::Put(
-      ordered_map, obj1, factory->the_hole_value());
-  ordered_map = OrderedHashMap::Put(
-      ordered_map, obj2, factory->the_hole_value());
-  ordered_map = OrderedHashMap::Put(
-      ordered_map, obj3, factory->the_hole_value());
+  ordered_map = OrderedHashMap::Remove(ordered_map, obj);
+  ordered_map = OrderedHashMap::Remove(ordered_map, obj1);
+  ordered_map = OrderedHashMap::Remove(ordered_map, obj2);
+  ordered_map = OrderedHashMap::Remove(ordered_map, obj3);
   CHECK_EQ(1, ordered_map->NumberOfElements());
   CHECK_EQ(2, ordered_map->NumberOfBuckets());
 }
 
 
 }