Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(145)

Issue 309653005: download_actuals.py: download JSON files from Google Storage instead of skia-autogen (Closed)

Created:
6 years, 6 months ago by epoger
Modified:
6 years, 6 months ago
Reviewers:
rmistry, benchen
CC:
skia-review_googlegroups.com, borenet, benchen
Base URL:
https://skia.googlesource.com/skia.git@master
Visibility:
Public.

Description

download_actuals.py: download JSON files from Google Storage instead of skia-autogen uses google-api-python-client instead of gsutil binary to interact with Google Storage BUG=skia:553 Committed: https://skia.googlesource.com/skia/+/55ada0630e1ce1bfd6e6e60b70370384530622cc

Patch Set 1 #

Total comments: 15

Patch Set 2 : Ravi comments #

Patch Set 3 : expand list comprehensions to be more readable #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+68 lines, -14 lines) Patch
M DEPS View 2 chunks +2 lines, -6 lines 0 comments Download
M gm/rebaseline_server/download_actuals.py View 1 2 5 chunks +64 lines, -8 lines 1 comment Download
M gm/rebaseline_server/server.py View 1 chunk +2 lines, -0 lines 0 comments Download

Messages

Total messages: 10 (0 generated)
epoger
Ravi- PTAL. Eric/Ben- I'm trying a new way of accessing Google Storage (google-api-python-client instead of ...
6 years, 6 months ago (2014-05-30 22:11:35 UTC) #1
benchen
Thanks for trying this out! Using an api certainly sounds better than calling a binary.. ...
6 years, 6 months ago (2014-05-30 23:45:03 UTC) #2
epoger
ravi: ping
6 years, 6 months ago (2014-06-03 12:01:53 UTC) #3
rmistry
Kudos for trying out this approach. https://codereview.chromium.org/309653005/diff/1/gm/rebaseline_server/download_actuals.py File gm/rebaseline_server/download_actuals.py (right): https://codereview.chromium.org/309653005/diff/1/gm/rebaseline_server/download_actuals.py#newcode174 gm/rebaseline_server/download_actuals.py:174: subdir += '/' ...
6 years, 6 months ago (2014-06-03 12:23:39 UTC) #4
epoger
https://codereview.chromium.org/309653005/diff/1/gm/rebaseline_server/download_actuals.py File gm/rebaseline_server/download_actuals.py (right): https://codereview.chromium.org/309653005/diff/1/gm/rebaseline_server/download_actuals.py#newcode174 gm/rebaseline_server/download_actuals.py:174: subdir += '/' On 2014/06/03 12:23:39, rmistry wrote: > ...
6 years, 6 months ago (2014-06-03 15:27:52 UTC) #5
epoger
https://codereview.chromium.org/309653005/diff/40001/gm/rebaseline_server/download_actuals.py File gm/rebaseline_server/download_actuals.py (right): https://codereview.chromium.org/309653005/diff/40001/gm/rebaseline_server/download_actuals.py#newcode191 gm/rebaseline_server/download_actuals.py:191: for dir_fullpath in results.get('prefixes', []): Ravi- I hope this ...
6 years, 6 months ago (2014-06-03 17:08:31 UTC) #6
rmistry
LGTM
6 years, 6 months ago (2014-06-03 17:23:15 UTC) #7
epoger
The CQ bit was checked by epoger@google.com
6 years, 6 months ago (2014-06-03 17:23:45 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://skia-tree-status.appspot.com/cq/epoger@google.com/309653005/40001
6 years, 6 months ago (2014-06-03 17:24:09 UTC) #9
commit-bot: I haz the power
6 years, 6 months ago (2014-06-03 17:35:32 UTC) #10
Message was sent while issue was closed.
Change committed as 55ada0630e1ce1bfd6e6e60b70370384530622cc

Powered by Google App Engine
This is Rietveld 408576698