Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(357)

Issue 309653003: Clean up (Get|Set)Property(Attributes)WithFailedAccessChecks (Closed)

Created:
6 years, 6 months ago by Toon Verwaest
Modified:
6 years, 6 months ago
Reviewers:
Igor Sheludko
CC:
v8-dev
Visibility:
Public.

Description

Clean up (Get|Set)Property(Attributes)WithFailedAccessChecks BUG= R=ishell@chromium.org Committed: https://code.google.com/p/v8/source/detail?r=21595

Patch Set 1 #

Patch Set 2 : Addressed comments #

Patch Set 3 : #

Patch Set 4 : #

Patch Set 5 : #

Patch Set 6 : #

Patch Set 7 : Addressed comment #

Unified diffs Side-by-side diffs Delta from patch set Stats (+100 lines, -188 lines) Patch
M src/objects.h View 1 3 4 5 1 chunk +4 lines, -4 lines 0 comments Download
M src/objects.cc View 1 2 3 4 5 6 16 chunks +96 lines, -184 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
Toon Verwaest
PTAL
6 years, 6 months ago (2014-05-30 11:48:31 UTC) #1
Igor Sheludko
lgtm
6 years, 6 months ago (2014-06-02 09:21:23 UTC) #2
Toon Verwaest
6 years, 6 months ago (2014-06-02 10:59:17 UTC) #3
Message was sent while issue was closed.
Committed patchset #7 manually as r21595 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698