Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(197)

Issue 309643008: Use default wallpaper when user wallpaper info points to empty file path. (Closed)

Created:
6 years, 6 months ago by Alexander Alekseev
Modified:
6 years, 6 months ago
Reviewers:
Nikita (slow), bshe
CC:
chromium-reviews, stevenjb+watch_chromium.org, davemoore+watch_chromium.org, oshima+watch_chromium.org, nkostylev+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Visibility:
Public.

Description

Use default wallpaper when user wallpaper info points to empty file path. In tests user wallpaper info can point to empty paths. Use default wallpaper in this case. BUG=371295 TEST=none Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=274383

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+10 lines, -7 lines) Patch
M chrome/browser/chromeos/login/users/wallpaper/wallpaper_manager.cc View 3 chunks +10 lines, -7 lines 0 comments Download

Messages

Total messages: 7 (0 generated)
Alexander Alekseev
Please review.
6 years, 6 months ago (2014-06-02 17:17:13 UTC) #1
Nikita (slow)
lgtm
6 years, 6 months ago (2014-06-02 17:50:31 UTC) #2
bshe
On 2014/06/02 17:50:31, Nikita Kostylev wrote: > lgtm lgtm
6 years, 6 months ago (2014-06-02 18:37:18 UTC) #3
Alexander Alekseev
The CQ bit was checked by alemate@chromium.org
6 years, 6 months ago (2014-06-02 18:46:58 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/alemate@chromium.org/309643008/1
6 years, 6 months ago (2014-06-02 18:48:00 UTC) #5
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: android_dbg_triggered_tests on tryserver.chromium ...
6 years, 6 months ago (2014-06-02 22:52:45 UTC) #6
commit-bot: I haz the power
6 years, 6 months ago (2014-06-03 00:06:27 UTC) #7
Message was sent while issue was closed.
Change committed as 274383

Powered by Google App Engine
This is Rietveld 408576698