Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(361)

Issue 309643006: Desktop user manager: Icons for supervised users. (Closed)

Created:
6 years, 6 months ago by Marc Treib
Modified:
6 years, 6 months ago
CC:
chromium-reviews, arv+watch_chromium.org, oshima+watch_chromium.org
Visibility:
Public.

Description

Desktop user manager: Icons for supervised users. Followup to https://codereview.chromium.org/307483002/ that adds the new resources. BUG=372812, 310640 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=276470

Patch Set 1 #

Patch Set 2 : Fix upload #

Patch Set 3 : ...again? #

Patch Set 4 : rebase #

Patch Set 5 : again #

Patch Set 6 : rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -2 lines) Patch
A chrome/app/theme/default_100_percent/common/icon_supervised.png View Binary file 0 comments Download
A chrome/app/theme/default_200_percent/common/icon_supervised.png View Binary file 0 comments Download
M chrome/app/theme/theme_resources.grd View 1 2 3 4 5 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/resources/user_manager/user_manager.css View 1 chunk +1 line, -2 lines 0 comments Download

Messages

Total messages: 46 (0 generated)
Marc Treib
pam: Please look at user_manager.css. oshima: Please look at c/a/theme changes. Thanks!
6 years, 6 months ago (2014-06-02 14:06:11 UTC) #1
Pam (message me for reviews)
c/b/resources/* LGTM It would be nice to (re)name constants so the difference between IDR_MANAGED_USER_ICON and ...
6 years, 6 months ago (2014-06-03 08:57:13 UTC) #2
oshima
lgtm On 2014/06/03 08:57:13, Pam (also PM for reviews) wrote: > c/b/resources/* LGTM > > ...
6 years, 6 months ago (2014-06-04 00:00:47 UTC) #3
Marc Treib
The CQ bit was checked by treib@chromium.org
6 years, 6 months ago (2014-06-04 07:25:17 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/treib@chromium.org/309643006/60001
6 years, 6 months ago (2014-06-04 07:26:47 UTC) #5
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: android_aosp on tryserver.chromium ...
6 years, 6 months ago (2014-06-04 08:24:05 UTC) #6
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 6 months ago (2014-06-04 08:26:27 UTC) #7
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_chromeos_rel on tryserver.chromium (http://build.chromium.org/p/tryserver.chromium/builders/linux_chromium_chromeos_rel/builds/34165) linux_chromium_gn_rel on tryserver.chromium (http://build.chromium.org/p/tryserver.chromium/builders/linux_chromium_gn_rel/builds/13085)
6 years, 6 months ago (2014-06-04 08:26:28 UTC) #8
Marc Treib
The CQ bit was checked by treib@chromium.org
6 years, 6 months ago (2014-06-04 08:31:03 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/treib@chromium.org/309643006/80001
6 years, 6 months ago (2014-06-04 08:33:00 UTC) #10
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: android_aosp on tryserver.chromium ...
6 years, 6 months ago (2014-06-04 09:13:55 UTC) #11
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 6 months ago (2014-06-04 09:18:53 UTC) #12
commit-bot: I haz the power
Try jobs failed on following builders: android_chromium_gn_compile_rel on tryserver.chromium (http://build.chromium.org/p/tryserver.chromium/builders/android_chromium_gn_compile_rel/builds/10265) android_clang_dbg on tryserver.chromium (http://build.chromium.org/p/tryserver.chromium/builders/android_clang_dbg/builds/148573) android_dbg ...
6 years, 6 months ago (2014-06-04 09:18:54 UTC) #13
Marc Treib
The CQ bit was checked by treib@chromium.org
6 years, 6 months ago (2014-06-04 09:21:17 UTC) #14
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/treib@chromium.org/309643006/80001
6 years, 6 months ago (2014-06-04 09:22:38 UTC) #15
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: android_aosp on tryserver.chromium ...
6 years, 6 months ago (2014-06-04 09:43:45 UTC) #16
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 6 months ago (2014-06-04 09:46:48 UTC) #17
commit-bot: I haz the power
Try jobs failed on following builders: android_chromium_gn_compile_rel on tryserver.chromium (http://build.chromium.org/p/tryserver.chromium/builders/android_chromium_gn_compile_rel/builds/10274) android_dbg on tryserver.chromium (http://build.chromium.org/p/tryserver.chromium/builders/android_dbg/builds/191741) chromium_presubmit ...
6 years, 6 months ago (2014-06-04 09:46:49 UTC) #18
Marc Treib
The CQ bit was checked by treib@chromium.org
6 years, 6 months ago (2014-06-04 10:33:16 UTC) #19
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/treib@chromium.org/309643006/100001
6 years, 6 months ago (2014-06-04 10:34:48 UTC) #20
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: android_aosp on tryserver.chromium ...
6 years, 6 months ago (2014-06-04 10:59:46 UTC) #21
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 6 months ago (2014-06-04 11:01:59 UTC) #22
commit-bot: I haz the power
Try jobs failed on following builders: android_chromium_gn_compile_rel on tryserver.chromium (http://build.chromium.org/p/tryserver.chromium/builders/android_chromium_gn_compile_rel/builds/10283)
6 years, 6 months ago (2014-06-04 11:02:01 UTC) #23
Marc Treib
The CQ bit was checked by treib@chromium.org
6 years, 6 months ago (2014-06-04 11:04:53 UTC) #24
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/treib@chromium.org/309643006/100001
6 years, 6 months ago (2014-06-04 11:05:39 UTC) #25
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: android_aosp on tryserver.chromium ...
6 years, 6 months ago (2014-06-04 11:21:27 UTC) #26
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 6 months ago (2014-06-04 11:23:37 UTC) #27
commit-bot: I haz the power
Try jobs failed on following builders: android_clang_dbg on tryserver.chromium (http://build.chromium.org/p/tryserver.chromium/builders/android_clang_dbg/builds/148594) linux_chromium_gn_rel on tryserver.chromium (http://build.chromium.org/p/tryserver.chromium/builders/linux_chromium_gn_rel/builds/13115) linux_chromium_rel ...
6 years, 6 months ago (2014-06-04 11:23:37 UTC) #28
Marc Treib
The CQ bit was checked by treib@chromium.org
6 years, 6 months ago (2014-06-04 12:09:53 UTC) #29
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/treib@chromium.org/309643006/100001
6 years, 6 months ago (2014-06-04 12:10:55 UTC) #30
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: android_aosp on tryserver.chromium ...
6 years, 6 months ago (2014-06-04 12:38:15 UTC) #31
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 6 months ago (2014-06-04 12:42:53 UTC) #32
commit-bot: I haz the power
Try jobs failed on following builders: android_chromium_gn_compile_rel on tryserver.chromium (http://build.chromium.org/p/tryserver.chromium/builders/android_chromium_gn_compile_rel/builds/10293) chromium_presubmit on tryserver.chromium (http://build.chromium.org/p/tryserver.chromium/builders/chromium_presubmit/builds/71555) linux_chromium_chromeos_rel ...
6 years, 6 months ago (2014-06-04 12:42:54 UTC) #33
Marc Treib
The CQ bit was checked by treib@chromium.org
6 years, 6 months ago (2014-06-04 14:28:00 UTC) #34
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/treib@chromium.org/309643006/100001
6 years, 6 months ago (2014-06-04 14:29:23 UTC) #35
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: android_chromium_gn_compile_rel on tryserver.chromium ...
6 years, 6 months ago (2014-06-04 17:47:29 UTC) #36
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 6 months ago (2014-06-04 17:55:41 UTC) #37
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_gn_rel on tryserver.chromium (http://build.chromium.org/p/tryserver.chromium/builders/linux_chromium_gn_rel/builds/13229)
6 years, 6 months ago (2014-06-04 17:55:42 UTC) #38
Marc Treib
The CQ bit was checked by treib@chromium.org
6 years, 6 months ago (2014-06-04 20:16:29 UTC) #39
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/treib@chromium.org/309643006/100001
6 years, 6 months ago (2014-06-04 20:21:23 UTC) #40
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: linux_chromium_gn_rel on tryserver.chromium ...
6 years, 6 months ago (2014-06-04 20:27:32 UTC) #41
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 6 months ago (2014-06-04 20:36:13 UTC) #42
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_gn_rel on tryserver.chromium (http://build.chromium.org/p/tryserver.chromium/builders/linux_chromium_gn_rel/builds/13342)
6 years, 6 months ago (2014-06-04 20:36:13 UTC) #43
Marc Treib
The CQ bit was checked by treib@chromium.org
6 years, 6 months ago (2014-06-11 09:44:34 UTC) #44
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/treib@chromium.org/309643006/120001
6 years, 6 months ago (2014-06-11 09:47:24 UTC) #45
commit-bot: I haz the power
6 years, 6 months ago (2014-06-11 19:11:33 UTC) #46
Message was sent while issue was closed.
Change committed as 276470

Powered by Google App Engine
This is Rietveld 408576698