Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(964)

Issue 309643003: Document the new policy loading logic starting with Chrome 35. (Closed)

Created:
6 years, 6 months ago by Joao da Silva
Modified:
6 years, 6 months ago
Reviewers:
pastarmovj
CC:
chromium-reviews, joaodasilva+watch_chromium.org
Visibility:
Public.

Description

Document the new policy loading logic starting with Chrome 35. BUG=378217 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=273993

Patch Set 1 #

Total comments: 2

Patch Set 2 : fixed doc #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -1 line) Patch
M components/policy/resources/policy_templates.json View 1 1 chunk +3 lines, -1 line 0 comments Download

Messages

Total messages: 6 (0 generated)
Joao da Silva
PTAL
6 years, 6 months ago (2014-05-30 09:02:34 UTC) #1
pastarmovj
LGTM with two things to correct please. https://codereview.chromium.org/309643003/diff/1/components/policy/resources/policy_templates.json File components/policy/resources/policy_templates.json (right): https://codereview.chromium.org/309643003/diff/1/components/policy/resources/policy_templates.json#newcode6472 components/policy/resources/policy_templates.json:6472: Starting with ...
6 years, 6 months ago (2014-05-30 12:43:11 UTC) #2
Joao da Silva
Thanks for reviewing! https://codereview.chromium.org/309643003/diff/1/components/policy/resources/policy_templates.json File components/policy/resources/policy_templates.json (right): https://codereview.chromium.org/309643003/diff/1/components/policy/resources/policy_templates.json#newcode6472 components/policy/resources/policy_templates.json:6472: Starting with <ph name="PRODUCT_NAME">$1<ex>Google Chrome</ex></ph> 35, ...
6 years, 6 months ago (2014-05-30 21:05:02 UTC) #3
Joao da Silva
The CQ bit was checked by joaodasilva@chromium.org
6 years, 6 months ago (2014-05-30 21:05:05 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/joaodasilva@chromium.org/309643003/20001
6 years, 6 months ago (2014-05-30 21:06:43 UTC) #5
commit-bot: I haz the power
6 years, 6 months ago (2014-05-31 02:17:37 UTC) #6
Message was sent while issue was closed.
Change committed as 273993

Powered by Google App Engine
This is Rietveld 408576698