Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(343)

Issue 30963002: DEFINE_CSS_VALUE_TYPE_CASTS starts to use DEFINE_TYPE_CASTS (Closed)

Created:
7 years, 2 months ago by gyuyoung-inactive
Modified:
7 years, 2 months ago
Reviewers:
tkent
CC:
blink-reviews, dglazkov+blink, apavlov+blink_chromium.org, darktears
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Visibility:
Public.

Description

DEFINE_CSS_VALUE_TYPE_CASTS starts to use DEFINE_TYPE_CASTS DEFINE_CSS_VALUE_TYPE_CASTS starts to use DEFINE_TYPE_CASTS so that it is more flexible. Under this change, unusual CSS child values also will be able to use the DEFINE_CSS_VALUE_TYPE_CASTS. BUG=N/A Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=160030

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+36 lines, -47 lines) Patch
M Source/core/css/CSSArrayFunctionValue.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/css/CSSAspectRatioValue.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/css/CSSBorderImageSliceValue.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/css/CSSCalculationValue.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/css/CSSCanvasValue.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/css/CSSCrossfadeValue.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/css/CSSCursorImageValue.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/css/CSSFilterValue.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/css/CSSFontFaceSrcValue.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/css/CSSFontFeatureValue.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/css/CSSFontValue.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/css/CSSFunctionValue.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/css/CSSGradientValue.h View 3 chunks +3 lines, -3 lines 0 comments Download
M Source/core/css/CSSGridTemplateValue.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/css/CSSImageGeneratorValue.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/css/CSSImageSetValue.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/css/CSSImageValue.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/css/CSSInheritedValue.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/css/CSSInitialValue.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/css/CSSLineBoxContainValue.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/css/CSSMixFunctionValue.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/css/CSSPrimitiveValue.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/css/CSSReflectValue.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/css/CSSSVGDocumentValue.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/css/CSSShaderValue.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/css/CSSShadowValue.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/css/CSSTimingFunctionValue.h View 2 chunks +2 lines, -2 lines 0 comments Download
M Source/core/css/CSSTransformValue.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/css/CSSUnicodeRangeValue.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/css/CSSValue.h View 1 chunk +2 lines, -13 lines 0 comments Download
M Source/core/css/CSSValueList.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/css/CSSVariableValue.h View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 4 (0 generated)
gyuyoung-inactive
Kent, sorry for my previous mistake. I fixed the problem.
7 years, 2 months ago (2013-10-20 13:15:14 UTC) #1
tkent
lgtm
7 years, 2 months ago (2013-10-20 21:47:07 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/gyuyoung.kim@samsung.com/30963002/1
7 years, 2 months ago (2013-10-20 21:47:19 UTC) #3
commit-bot: I haz the power
7 years, 2 months ago (2013-10-20 22:41:39 UTC) #4
Message was sent while issue was closed.
Change committed as 160030

Powered by Google App Engine
This is Rietveld 408576698