Tenure allocation sites only when semi-space is maximum size.

test/cctest/test-heap.cc

 // Copyright 2012 the V8 project authors. All rights reserved.
 // Redistribution and use in source and binary forms, with or without
 // modification, are permitted provided that the following conditions are
 // met:
 //
 //     * Redistributions of source code must retain the above copyright
 //       notice, this list of conditions and the following disclaimer.
 //     * Redistributions in binary form must reproduce the above
 //       copyright notice, this list of conditions and the following
 //       disclaimer in the documentation and/or other materials provided
@@ skipping 2177 matching lines @@
   Handle<JSObject> o =
       v8::Utils::OpenHandle(*v8::Handle<v8::Object>::Cast(res));
 
   CHECK(CcTest::heap()->InNewSpace(*o));
 }
 
 
 TEST(OptimizedPretenuringAllocationFolding) {
   i::FLAG_allow_natives_syntax = true;
   i::FLAG_expose_gc = true;
+  i::FLAG_min_semi_space_size = 8;

[mvstanton, 2014/06/02 13:31:25]

Why is this being done? Probably worth a comment.

[Hannes Payer (out of office), 2014/06/02 14:56:52]

Done.

   CcTest::InitializeVM();
   if (!CcTest::i_isolate()->use_crankshaft() || i::FLAG_always_opt) return;
   if (i::FLAG_gc_global || i::FLAG_stress_compaction) return;
   v8::HandleScope scope(CcTest::isolate());
 
   i::ScopedVector<char> source(1024);
   i::OS::SNPrintF(
       source,
       "var number_elements = %d;"
       "var elements = new Array();"
@@ skipping 24 matching lines @@
   CHECK(CcTest::heap()->InOldPointerSpace(*int_array_handle));
   CHECK(CcTest::heap()->InOldPointerSpace(int_array_handle->elements()));
   CHECK(CcTest::heap()->InOldPointerSpace(*double_array_handle));
   CHECK(CcTest::heap()->InOldDataSpace(double_array_handle->elements()));
 }
 
 
 TEST(OptimizedPretenuringObjectArrayLiterals) {
   i::FLAG_allow_natives_syntax = true;
   i::FLAG_expose_gc = true;
+  i::FLAG_min_semi_space_size = 8;
   CcTest::InitializeVM();
   if (!CcTest::i_isolate()->use_crankshaft() || i::FLAG_always_opt) return;
   if (i::FLAG_gc_global || i::FLAG_stress_compaction) return;
   v8::HandleScope scope(CcTest::isolate());
 
   i::ScopedVector<char> source(1024);
   i::OS::SNPrintF(
       source,
       "var number_elements = %d;"
       "var elements = new Array(number_elements);"
@@ skipping 15 matching lines @@
       v8::Utils::OpenHandle(*v8::Handle<v8::Object>::Cast(res));
 
   CHECK(CcTest::heap()->InOldPointerSpace(o->elements()));
   CHECK(CcTest::heap()->InOldPointerSpace(*o));
 }
 
 
 TEST(OptimizedPretenuringMixedInObjectProperties) {
   i::FLAG_allow_natives_syntax = true;
   i::FLAG_expose_gc = true;
+  i::FLAG_min_semi_space_size = 8;
   CcTest::InitializeVM();
   if (!CcTest::i_isolate()->use_crankshaft() || i::FLAG_always_opt) return;
   if (i::FLAG_gc_global || i::FLAG_stress_compaction) return;
   v8::HandleScope scope(CcTest::isolate());
 
   i::ScopedVector<char> source(1024);
   i::OS::SNPrintF(
       source,
       "var number_elements = %d;"
       "var elements = new Array(number_elements);"
@@ skipping 21 matching lines @@
   JSObject* inner_object = reinterpret_cast<JSObject*>(o->RawFastPropertyAt(0));
   CHECK(CcTest::heap()->InOldPointerSpace(inner_object));
   CHECK(CcTest::heap()->InOldDataSpace(inner_object->RawFastPropertyAt(0)));
   CHECK(CcTest::heap()->InOldPointerSpace(inner_object->RawFastPropertyAt(1)));
 }
 
 
 TEST(OptimizedPretenuringDoubleArrayProperties) {
   i::FLAG_allow_natives_syntax = true;
   i::FLAG_expose_gc = true;
+  i::FLAG_min_semi_space_size = 8;
   CcTest::InitializeVM();
   if (!CcTest::i_isolate()->use_crankshaft() || i::FLAG_always_opt) return;
   if (i::FLAG_gc_global || i::FLAG_stress_compaction) return;
   v8::HandleScope scope(CcTest::isolate());
 
   i::ScopedVector<char> source(1024);
   i::OS::SNPrintF(
       source,
       "var number_elements = %d;"
       "var elements = new Array(number_elements);"
@@ skipping 15 matching lines @@
       v8::Utils::OpenHandle(*v8::Handle<v8::Object>::Cast(res));
 
   CHECK(CcTest::heap()->InOldPointerSpace(*o));
   CHECK(CcTest::heap()->InOldDataSpace(o->properties()));
 }
 
 
 TEST(OptimizedPretenuringdoubleArrayLiterals) {
   i::FLAG_allow_natives_syntax = true;
   i::FLAG_expose_gc = true;
+  i::FLAG_min_semi_space_size = 8;
   CcTest::InitializeVM();
   if (!CcTest::i_isolate()->use_crankshaft() || i::FLAG_always_opt) return;
   if (i::FLAG_gc_global || i::FLAG_stress_compaction) return;
   v8::HandleScope scope(CcTest::isolate());
 
   i::ScopedVector<char> source(1024);
   i::OS::SNPrintF(
       source,
       "var number_elements = %d;"
       "var elements = new Array(number_elements);"
@@ skipping 15 matching lines @@
       v8::Utils::OpenHandle(*v8::Handle<v8::Object>::Cast(res));
 
   CHECK(CcTest::heap()->InOldDataSpace(o->elements()));
   CHECK(CcTest::heap()->InOldPointerSpace(*o));
 }
 
 
 TEST(OptimizedPretenuringNestedMixedArrayLiterals) {
   i::FLAG_allow_natives_syntax = true;
   i::FLAG_expose_gc = true;
+  i::FLAG_min_semi_space_size = 8;
   CcTest::InitializeVM();
   if (!CcTest::i_isolate()->use_crankshaft() || i::FLAG_always_opt) return;
   if (i::FLAG_gc_global || i::FLAG_stress_compaction) return;
   v8::HandleScope scope(CcTest::isolate());
 
   i::ScopedVector<char> source(1024);
   i::OS::SNPrintF(
       source,
       "var number_elements = 100;"
       "var elements = new Array(number_elements);"
@@ skipping 24 matching lines @@
   CHECK(CcTest::heap()->InOldPointerSpace(*int_array_handle));
   CHECK(CcTest::heap()->InOldPointerSpace(int_array_handle->elements()));
   CHECK(CcTest::heap()->InOldPointerSpace(*double_array_handle));
   CHECK(CcTest::heap()->InOldDataSpace(double_array_handle->elements()));
 }
 
 
 TEST(OptimizedPretenuringNestedObjectLiterals) {
   i::FLAG_allow_natives_syntax = true;
   i::FLAG_expose_gc = true;
+  i::FLAG_min_semi_space_size = 8;
   CcTest::InitializeVM();
   if (!CcTest::i_isolate()->use_crankshaft() || i::FLAG_always_opt) return;
   if (i::FLAG_gc_global || i::FLAG_stress_compaction) return;
   v8::HandleScope scope(CcTest::isolate());
 
   i::ScopedVector<char> source(1024);
   i::OS::SNPrintF(
       source,
       "var number_elements = %d;"
       "var elements = new Array(number_elements);"
@@ skipping 24 matching lines @@
   CHECK(CcTest::heap()->InOldPointerSpace(*int_array_handle_1));
   CHECK(CcTest::heap()->InOldPointerSpace(int_array_handle_1->elements()));
   CHECK(CcTest::heap()->InOldPointerSpace(*int_array_handle_2));
   CHECK(CcTest::heap()->InOldPointerSpace(int_array_handle_2->elements()));
 }
 
 
 TEST(OptimizedPretenuringNestedDoubleLiterals) {
   i::FLAG_allow_natives_syntax = true;
   i::FLAG_expose_gc = true;
+  i::FLAG_min_semi_space_size = 8;
   CcTest::InitializeVM();
   if (!CcTest::i_isolate()->use_crankshaft() || i::FLAG_always_opt) return;
   if (i::FLAG_gc_global || i::FLAG_stress_compaction) return;
   v8::HandleScope scope(CcTest::isolate());
 
   i::ScopedVector<char> source(1024);
   i::OS::SNPrintF(
       source,
       "var number_elements = %d;"
       "var elements = new Array(number_elements);"
@@ skipping 32 matching lines @@
 
 // Make sure pretenuring feedback is gathered for constructed objects as well
 // as for literals.
 TEST(OptimizedPretenuringConstructorCalls) {
   if (!i::FLAG_pretenuring_call_new) {
     // FLAG_pretenuring_call_new needs to be synced with the snapshot.
     return;
   }
   i::FLAG_allow_natives_syntax = true;
   i::FLAG_expose_gc = true;
+  i::FLAG_min_semi_space_size = 8;
   CcTest::InitializeVM();
   if (!CcTest::i_isolate()->use_crankshaft() || i::FLAG_always_opt) return;
   if (i::FLAG_gc_global || i::FLAG_stress_compaction) return;
   v8::HandleScope scope(CcTest::isolate());
 
   i::ScopedVector<char> source(1024);
   // Call new is doing slack tracking for the first
   // JSFunction::kGenerousAllocationCount allocations, and we can't find
   // mementos during that time.
   i::OS::SNPrintF(
@@ skipping 26 matching lines @@
 }
 
 
 TEST(OptimizedPretenuringCallNew) {
   if (!i::FLAG_pretenuring_call_new) {
     // FLAG_pretenuring_call_new needs to be synced with the snapshot.
     return;
   }
   i::FLAG_allow_natives_syntax = true;
   i::FLAG_expose_gc = true;
+  i::FLAG_min_semi_space_size = 8;
   CcTest::InitializeVM();
   if (!CcTest::i_isolate()->use_crankshaft() || i::FLAG_always_opt) return;
   if (i::FLAG_gc_global || i::FLAG_stress_compaction) return;
   v8::HandleScope scope(CcTest::isolate());
 
   i::ScopedVector<char> source(1024);
   // Call new is doing slack tracking for the first
   // JSFunction::kGenerousAllocationCount allocations, and we can't find
   // mementos during that time.
   i::OS::SNPrintF(
@@ skipping 1693 matching lines @@
   // Type cast checks fail because the path tracer abuses the map for marking.
   if (i::FLAG_enable_slow_asserts) return;
   CcTest::InitializeVM();
   v8::HandleScope scope(CcTest::isolate());
 
   v8::Local<v8::Value> result = CompileRun("'abc'");
   Handle<Object> o = v8::Utils::OpenHandle(*result);
   CcTest::i_isolate()->heap()->TracePathToObject(*o);
 }
 #endif  // DEBUG