chrome/browser/chromeos/extensions/input_method_apitest_chromeos.cc - Issue 309623005: Remove the flag g_use_wrapped_extension_keyboard_layouts.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/chromeos/extensions/input_method_apitest_chromeos.cc

Issue 309623005: Remove the flag g_use_wrapped_extension_keyboard_layouts. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 6 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/chromeos/extensions/input_method_api.cc ('k') | chrome/browser/chromeos/input_method/component_extension_ime_manager_impl.cc » ('j') | chrome/browser/chromeos/input_method/input_method_manager_impl_unittest.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/chromeos/extensions/input_method_apitest_chromeos.cc

diff --git a/chrome/browser/chromeos/extensions/input_method_apitest_chromeos.cc b/chrome/browser/chromeos/extensions/input_method_apitest_chromeos.cc

index 5ae87909d04f93c2bf17c2efe1c444080dec9dd5..5fa5e5bb56c6025e793fff45fdf9e0e70ad43fc1 100644

--- a/chrome/browser/chromeos/extensions/input_method_apitest_chromeos.cc

+++ b/chrome/browser/chromeos/extensions/input_method_apitest_chromeos.cc

@@ -58,7 +58,7 @@ class SetInputMethodListener : public content::NotificationObserver {

std::vector<std::string> keyboard_layouts;

keyboard_layouts.push_back(

- chromeos::extension_ime_util::GetInputMethodIDByKeyboardLayout(

+ chromeos::extension_ime_util::GetInputMethodIDByEngineID(

kInitialInputMethodOnLoginScreen));

manager->EnableLoginLayouts(kLoginScreenUILanguage, keyboard_layouts);

return;

@@ -68,7 +68,7 @@ class SetInputMethodListener : public content::NotificationObserver {

base::StringPrintf("%s:%s", kSetInputMethodMessage, kNewInputMethod);

if (content == expected_message) {

chromeos::input_method::InputMethodManager::Get()->ChangeInputMethod(

- chromeos::extension_ime_util::GetInputMethodIDByKeyboardLayout(

+ chromeos::extension_ime_util::GetInputMethodIDByEngineID(

base::StringPrintf("xkb:%s", kNewInputMethod)));

scoped_refptr<extensions::TestSendMessageFunction> function =