Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(728)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 309623005: Remove the flag g_use_wrapped_extension_keyboard_layouts. (Closed)

Created:
6 years, 6 months ago by Shu Chen
Modified:
6 years, 6 months ago
CC:
chromium-reviews, extensions-reviews_chromium.org, yusukes+watch_chromium.org, yukishiino+watch_chromium.org, nona+watch_chromium.org, oshima+watch_chromium.org, chromium-apps-reviews_chromium.org, stevenjb+watch_chromium.org, davemoore+watch_chromium.org, nkostylev+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Visibility:
Public.

Description

[IME] Remove the flag g_use_wrapped_extension_keyboard_layouts, and clean up the scattered & hard-coded extension IDs. BUG=379437, 379449 TEST=None Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=274480

Patch Set 1 #

Patch Set 2 : #

Patch Set 3 : fixed browser_tests compile errors. #

Patch Set 4 : #

Patch Set 5 : #

Patch Set 6 : #

Total comments: 2

Patch Set 7 : #

Total comments: 6

Patch Set 8 : #

Patch Set 9 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+327 lines, -432 lines) Patch
M chrome/browser/chromeos/extensions/input_method_api.cc View 1 1 chunk +1 line, -2 lines 0 comments Download
M chrome/browser/chromeos/extensions/input_method_apitest_chromeos.cc View 1 2 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/chromeos/input_method/component_extension_ime_manager_impl.cc View 1 2 3 4 5 6 7 8 2 chunks +15 lines, -14 lines 0 comments Download
M chrome/browser/chromeos/input_method/input_method_manager_impl.cc View 1 2 3 4 5 6 7 8 5 chunks +10 lines, -12 lines 0 comments Download
M chrome/browser/chromeos/input_method/input_method_manager_impl_unittest.cc View 1 2 3 4 5 6 7 8 33 chunks +162 lines, -180 lines 0 comments Download
M chrome/browser/chromeos/input_method/input_method_util.cc View 1 2 3 4 5 6 7 8 10 chunks +41 lines, -77 lines 0 comments Download
M chrome/browser/chromeos/input_method/input_method_util_unittest.cc View 1 2 3 4 5 6 7 8 17 chunks +19 lines, -60 lines 0 comments Download
M chrome/browser/chromeos/input_method/mode_indicator_browsertest.cc View 1 2 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/chromeos/login/oobe_localization_browsertest.cc View 1 2 2 chunks +2 lines, -4 lines 0 comments Download
M chrome/browser/ui/webui/chromeos/login/network_screen_handler.cc View 1 2 3 4 5 4 chunks +12 lines, -20 lines 0 comments Download
M chromeos/ime/extension_ime_util.h View 1 2 3 4 3 chunks +26 lines, -18 lines 0 comments Download
M chromeos/ime/extension_ime_util.cc View 1 2 3 4 5 6 7 4 chunks +35 lines, -41 lines 0 comments Download

Messages

Total messages: 13 (0 generated)
Shu Chen
Nona/Nikita, can you please review this cl? Thanks
6 years, 6 months ago (2014-05-31 09:44:41 UTC) #1
Seigo Nonaka
lgtm with one nites https://codereview.chromium.org/309623005/diff/100001/chrome/browser/chromeos/input_method/input_method_manager_impl_unittest.cc File chrome/browser/chromeos/input_method/input_method_manager_impl_unittest.cc (right): https://codereview.chromium.org/309623005/diff/100001/chrome/browser/chromeos/input_method/input_method_manager_impl_unittest.cc#newcode57 chrome/browser/chromeos/input_method/input_method_manager_impl_unittest.cc:57: std::string Id(const std::string& id) { ...
6 years, 6 months ago (2014-06-02 03:48:26 UTC) #2
Shu Chen
https://codereview.chromium.org/309623005/diff/100001/chrome/browser/chromeos/input_method/input_method_manager_impl_unittest.cc File chrome/browser/chromeos/input_method/input_method_manager_impl_unittest.cc (right): https://codereview.chromium.org/309623005/diff/100001/chrome/browser/chromeos/input_method/input_method_manager_impl_unittest.cc#newcode57 chrome/browser/chromeos/input_method/input_method_manager_impl_unittest.cc:57: std::string Id(const std::string& id) { On 2014/06/02 03:48:26, Seigo ...
6 years, 6 months ago (2014-06-02 04:01:56 UTC) #3
Nikita (slow)
lgtm https://codereview.chromium.org/309623005/diff/120001/chromeos/ime/extension_ime_util.cc File chromeos/ime/extension_ime_util.cc (right): https://codereview.chromium.org/309623005/diff/120001/chromeos/ime/extension_ime_util.cc#newcode59 chromeos/ime/extension_ime_util.cc:59: StartsWithASCII(engine_id, kExtensionIMEPrefix, true)) nit: add {} since condition ...
6 years, 6 months ago (2014-06-02 06:13:46 UTC) #4
Shu Chen
https://codereview.chromium.org/309623005/diff/120001/chromeos/ime/extension_ime_util.cc File chromeos/ime/extension_ime_util.cc (right): https://codereview.chromium.org/309623005/diff/120001/chromeos/ime/extension_ime_util.cc#newcode59 chromeos/ime/extension_ime_util.cc:59: StartsWithASCII(engine_id, kExtensionIMEPrefix, true)) On 2014/06/02 06:13:47, Nikita Kostylev wrote: ...
6 years, 6 months ago (2014-06-02 09:51:20 UTC) #5
Shu Chen
The CQ bit was checked by shuchen@chromium.org
6 years, 6 months ago (2014-06-03 01:43:49 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/shuchen@chromium.org/309623005/160001
6 years, 6 months ago (2014-06-03 01:44:26 UTC) #7
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: linux_chromium_chromeos_clang_dbg on tryserver.chromium ...
6 years, 6 months ago (2014-06-03 05:13:19 UTC) #8
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 6 months ago (2014-06-03 07:27:59 UTC) #9
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_chromeos_clang_dbg on tryserver.chromium (http://build.chromium.org/p/tryserver.chromium/builders/linux_chromium_chromeos_clang_dbg/builds/20551)
6 years, 6 months ago (2014-06-03 07:27:59 UTC) #10
Shu Chen
The CQ bit was checked by shuchen@chromium.org
6 years, 6 months ago (2014-06-03 07:29:59 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/shuchen@chromium.org/309623005/160001
6 years, 6 months ago (2014-06-03 07:31:41 UTC) #12
commit-bot: I haz the power
6 years, 6 months ago (2014-06-03 12:20:35 UTC) #13
Message was sent while issue was closed. 
Change committed as 274480

Powered by Google App Engine
This is Rietveld 408576698