Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(137)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 309623002: device/bluetooth: Update GATT descriptor value D-Bus bindings. (Closed)

Created:
6 years, 6 months ago by armansito
Modified:
6 years, 6 months ago
Reviewers:
keybuk
CC:
chromium-reviews, stevenjb+watch_chromium.org, oshima+watch_chromium.org
Visibility:
Public.

Description

device/bluetooth: Update GATT descriptor value D-Bus bindings. This CL updates the Chrome D-Bus bindings and modifies the device/bluetooth GATT Chrome OS code to use the new bindings defined in crbug.com/378182 for descriptor value reads and writes. BUG=378182 TEST=device_unittests; manual tests using custom bluetoothd Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=275718

Patch Set 1 #

Total comments: 2

Patch Set 2 : Use constants from cros_system_api. #

Patch Set 3 : Rebased #

Patch Set 4 : Fix compile error. #

Patch Set 5 : Fixed clang error #

Unified diffs Side-by-side diffs Delta from patch set Stats (+255 lines, -123 lines) Patch
M chromeos/dbus/bluetooth_gatt_descriptor_client.h View 4 chunks +25 lines, -5 lines 0 comments Download
M chromeos/dbus/bluetooth_gatt_descriptor_client.cc View 1 4 chunks +105 lines, -1 line 0 comments Download
M chromeos/dbus/fake_bluetooth_gatt_descriptor_client.h View 1 2 3 4 2 chunks +15 lines, -1 line 0 comments Download
M chromeos/dbus/fake_bluetooth_gatt_descriptor_client.cc View 1 2 3 4 4 chunks +44 lines, -21 lines 0 comments Download
M device/bluetooth/bluetooth_gatt_chromeos_unittest.cc View 1 2 4 chunks +18 lines, -13 lines 0 comments Download
M device/bluetooth/bluetooth_remote_gatt_characteristic_chromeos.h View 1 2 1 chunk +0 lines, -3 lines 0 comments Download
M device/bluetooth/bluetooth_remote_gatt_characteristic_chromeos.cc View 1 2 3 1 chunk +0 lines, -24 lines 0 comments Download
M device/bluetooth/bluetooth_remote_gatt_descriptor_chromeos.h View 2 chunks +12 lines, -8 lines 0 comments Download
M device/bluetooth/bluetooth_remote_gatt_descriptor_chromeos.cc View 4 chunks +34 lines, -45 lines 0 comments Download
M device/bluetooth/bluetooth_remote_gatt_service_chromeos.h View 1 2 1 chunk +2 lines, -2 lines 0 comments Download

Messages

Total messages: 13 (0 generated)
armansito
6 years, 6 months ago (2014-05-30 01:26:44 UTC) #1
keybuk
https://codereview.chromium.org/309623002/diff/1/chromeos/dbus/bluetooth_gatt_descriptor_client.cc File chromeos/dbus/bluetooth_gatt_descriptor_client.cc (right): https://codereview.chromium.org/309623002/diff/1/chromeos/dbus/bluetooth_gatt_descriptor_client.cc#newcode22 chromeos/dbus/bluetooth_gatt_descriptor_client.cc:22: } // namespace Again, no reason not to do ...
6 years, 6 months ago (2014-05-30 22:23:41 UTC) #2
armansito
https://codereview.chromium.org/309623002/diff/1/chromeos/dbus/bluetooth_gatt_descriptor_client.cc File chromeos/dbus/bluetooth_gatt_descriptor_client.cc (right): https://codereview.chromium.org/309623002/diff/1/chromeos/dbus/bluetooth_gatt_descriptor_client.cc#newcode22 chromeos/dbus/bluetooth_gatt_descriptor_client.cc:22: } // namespace On 2014/05/30 22:23:41, keybuk wrote: > ...
6 years, 6 months ago (2014-06-05 06:13:51 UTC) #3
keybuk
lgtm
6 years, 6 months ago (2014-06-06 17:56:13 UTC) #4
armansito
The CQ bit was checked by armansito@chromium.org
6 years, 6 months ago (2014-06-07 22:19:31 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/armansito@chromium.org/309623002/40001
6 years, 6 months ago (2014-06-07 22:20:07 UTC) #6
armansito
The CQ bit was unchecked by armansito@chromium.org
6 years, 6 months ago (2014-06-07 22:21:30 UTC) #7
armansito
The CQ bit was checked by armansito@chromium.org
6 years, 6 months ago (2014-06-07 22:27:46 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/armansito@chromium.org/309623002/60001
6 years, 6 months ago (2014-06-07 22:28:10 UTC) #9
armansito
The CQ bit was unchecked by armansito@chromium.org
6 years, 6 months ago (2014-06-07 23:22:53 UTC) #10
armansito
The CQ bit was checked by armansito@chromium.org
6 years, 6 months ago (2014-06-07 23:28:07 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/armansito@chromium.org/309623002/80001
6 years, 6 months ago (2014-06-07 23:28:21 UTC) #12
commit-bot: I haz the power
6 years, 6 months ago (2014-06-08 02:09:59 UTC) #13
Message was sent while issue was closed. 
Change committed as 275718

Powered by Google App Engine
This is Rietveld 408576698