Issue 309613006: Un-inline Node's constructor to avoid bloating

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 309613006: Un-inline Node's constructor to avoid bloating (Closed)

Created:
6 years, 6 months ago by Inactive

Modified:
6 years, 6 months ago

Reviewers:
eseidel

CC:
blink-reviews, blink-reviews-dom_chromium.org, dglazkov+blink, sof, eae+blinkwatch, rwlbuis

Base URL:
svn://svn.chromium.org/blink/trunk

Visibility:
Public.

Un-inline Node's constructor to avoid bloating Un-inline Node's constructor to avoid bloating. Node's constructor is not trivial and Node is used in inheritance. This reduces the release binary size by ~4Kb. I did not see any impact on the Dromaeo score: http://dromaeo.com/?id=222265,222267 R=eseidel@chromium.org Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=175215

Created: 6 years, 6 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+21 lines, -19 lines)			Patch
	M	Source/core/dom/Node.h	View		1 chunk	+1 line, -19 lines	0 comments	Download
	M	Source/core/dom/Node.cpp	View		1 chunk	+20 lines, -0 lines	0 comments	Download

Total messages: 4 (0 generated)

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/ch.dumez@samsung.com/309613006/1

6 years, 6 months ago (2014-06-01 04:01:34 UTC) #3

Message was sent while issue was closed.

Change committed as 175215