[MemSheriff] LayoutTests leak RenderProcessHostImpl

[MemSheriff] LayoutTests leak RenderProcessHostImpl

LayoutTests delete all but one RenderProcessHostImpl message. That
means we need to suppress all leaks below RenderProcessHostImpl::Init
if it happens in a layout test.

BUG=367809
TBR=thestig@chromium.org, yzshen@chromium.org
NOTRY=true

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=273888

[groby-ooo-7-16, 2014-05-30 19:34:46]

The CQ bit was checked by groby@chromium.org

[commit-bot: I haz the power, 2014-05-30 19:37:19]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/groby@chromium.org/309613003/1

[commit-bot: I haz the power, 2014-05-30 19:40:13]

Change committed as 273888

[yzshen1, 2014-05-30 19:40:28]

On 2014/05/30 19:34:46, groby wrote:
> The CQ bit was checked by mailto:groby@chromium.org

Thanks for taking care of the issue!

I am not quite sure whether this suppression is too broad.
I will let someone who knows better (looking at thestig@) to decide. :)

[Lei Zhang, 2014-05-30 20:05:54]

On 2014/05/30 19:40:28, yzshen1 wrote:
> On 2014/05/30 19:34:46, groby wrote:
> > The CQ bit was checked by mailto:groby@chromium.org
> 
> Thanks for taking care of the issue!
> 
> I am not quite sure whether this suppression is too broad.
> I will let someone who knows better (looking at thestig@) to decide. :)

lgtm with the hope that the leak gets fixed soon. I don't want sheriffs playing
whack-a-mole either. Memory.fyi causes a lot of buildbot email spam.

[yzshen1, 2014-05-30 20:12:07]

On Fri, May 30, 2014 at 1:05 PM, <thestig@chromium.org> wrote:

> On 2014/05/30 19:40:28, yzshen1 wrote:
>
>> On 2014/05/30 19:34:46, groby wrote:
>> > The CQ bit was checked by mailto:groby@chromium.org
>>
>
>  Thanks for taking care of the issue!
>>
>
>  I am not quite sure whether this suppression is too broad.
>> I will let someone who knows better (looking at thestig@) to decide. :)
>>
>
> lgtm with the hope that the leak gets fixed soon. I don't want sheriffs
> playing
> whack-a-mole either. Memory.fyi causes a lot of buildbot email spam.
>

I will take a look at those new call stacks that groby added to 367809 to
see whether they revealed anything new.


>
> https://codereview.chromium.org/309613003/
>

To unsubscribe from this group and stop receiving emails from it, send an email
to chromium-reviews+unsubscribe@chromium.org.

[groby-ooo-7-16, 2014-05-30 20:25:26]

I doubt there are any new revelations - it's just more leaks under
RenderProccessHostImpl::Init. I think the bug identifies the cause - a
missing DeleteSoon.



On Fri, May 30, 2014 at 1:12 PM, Yuzhu Shen <yzshen@chromium.org> wrote:

>
>
>
> On Fri, May 30, 2014 at 1:05 PM, <thestig@chromium.org> wrote:
>
>> On 2014/05/30 19:40:28, yzshen1 wrote:
>>
>>> On 2014/05/30 19:34:46, groby wrote:
>>> > The CQ bit was checked by mailto:groby@chromium.org
>>>
>>
>>  Thanks for taking care of the issue!
>>>
>>
>>  I am not quite sure whether this suppression is too broad.
>>> I will let someone who knows better (looking at thestig@) to decide. :)
>>>
>>
>> lgtm with the hope that the leak gets fixed soon. I don't want sheriffs
>> playing
>> whack-a-mole either. Memory.fyi causes a lot of buildbot email spam.
>>
>
> I will take a look at those new call stacks that groby added to 367809 to
> see whether they revealed anything new.
>
>
>>
>> https://codereview.chromium.org/309613003/
>>
>
>

To unsubscribe from this group and stop receiving emails from it, send an email
to chromium-reviews+unsubscribe@chromium.org.