Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(58)

Issue 309593007: Expand GPU rasterization trigger for Finch experiment (Closed)

Created:
6 years, 6 months ago by ajuma
Modified:
6 years, 6 months ago
CC:
blink-reviews, jamesr, dglazkov+blink, abarth-chromium, Vangelis Kokkevis, ernstm, aelias_OOO_until_Jul13
Visibility:
Public.

Description

Expand GPU rasterization trigger for field trial This allows expanding the GPU rasterization trigger for a field trial. The expanded trigger is <meta name="viewport" content="width=device-width, minimum-scale=1.0"> BUG=380454 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=175699

Patch Set 1 #

Total comments: 3

Patch Set 2 : Use a WebSetting #

Unified diffs Side-by-side diffs Delta from patch set Stats (+75 lines, -7 lines) Patch
M Source/web/WebSettingsImpl.h View 1 3 chunks +3 lines, -0 lines 0 comments Download
M Source/web/WebSettingsImpl.cpp View 1 2 chunks +6 lines, -0 lines 0 comments Download
M Source/web/WebViewImpl.cpp View 1 1 chunk +13 lines, -7 lines 0 comments Download
M Source/web/tests/ViewportTest.cpp View 1 2 chunks +47 lines, -0 lines 0 comments Download
A Source/web/tests/data/viewport/viewport-gpu-rasterization-expanded-heuristics.html View 1 chunk +5 lines, -0 lines 0 comments Download
M public/web/WebSettings.h View 1 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 12 (0 generated)
ajuma
The chromium side of this is https://codereview.chromium.org/314753002/
6 years, 6 months ago (2014-06-04 01:05:54 UTC) #1
jamesr
Somebody working on the feature should review this
6 years, 6 months ago (2014-06-04 01:15:45 UTC) #2
aelias_OOO_until_Jul13
lgtm for Source/web. Still needs OWNERS for Source/public.
6 years, 6 months ago (2014-06-04 01:27:14 UTC) #3
ajuma
On 2014/06/04 01:27:14, aelias wrote: > lgtm for Source/web. Still needs OWNERS for Source/public. jamesr, ...
6 years, 6 months ago (2014-06-04 01:41:20 UTC) #4
blink-reviews
As I said someone involved in this should do the review. I'm not, so no. ...
6 years, 6 months ago (2014-06-04 01:57:03 UTC) #5
ajuma
+jochen, abarth for public/ OWNERS
6 years, 6 months ago (2014-06-04 02:14:22 UTC) #6
abarth-chromium
https://codereview.chromium.org/309593007/diff/1/public/web/WebViewClient.h File public/web/WebViewClient.h (right): https://codereview.chromium.org/309593007/diff/1/public/web/WebViewClient.h#newcode134 public/web/WebViewClient.h:134: virtual bool useExpandedHeuristicsForGpuRasterization() { return false; } This should ...
6 years, 6 months ago (2014-06-04 02:23:43 UTC) #7
ajuma
PTAL. https://codereview.chromium.org/309593007/diff/1/public/web/WebViewClient.h File public/web/WebViewClient.h (right): https://codereview.chromium.org/309593007/diff/1/public/web/WebViewClient.h#newcode134 public/web/WebViewClient.h:134: virtual bool useExpandedHeuristicsForGpuRasterization() { return false; } On ...
6 years, 6 months ago (2014-06-04 14:48:00 UTC) #8
abarth-chromium
lgtm
6 years, 6 months ago (2014-06-06 17:46:40 UTC) #9
abarth-chromium
The CQ bit was checked by abarth@chromium.org
6 years, 6 months ago (2014-06-06 17:46:43 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/ajuma@chromium.org/309593007/20001
6 years, 6 months ago (2014-06-06 17:47:03 UTC) #11
commit-bot: I haz the power
6 years, 6 months ago (2014-06-06 20:07:38 UTC) #12
Message was sent while issue was closed.
Change committed as 175699

Powered by Google App Engine
This is Rietveld 408576698