Issue 309593004: Un-inline Element's constructor to avoid bloating

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 309593004: Un-inline Element's constructor to avoid bloating (Closed)

Created:
6 years, 6 months ago by Inactive

Modified:
6 years, 6 months ago

Reviewers:
eseidel

CC:
blink-reviews, blink-reviews-dom_chromium.org, dglazkov+blink, sof, eae+blinkwatch, rwlbuis

Base URL:
svn://svn.chromium.org/blink/trunk

Visibility:
Public.

Un-inline Element's constructor to avoid bloating Un-inline Element's constructor to avoid bloating, as advised by Chromium coding style: http://www.chromium.org/developers/coding-style/cpp-dos-and-donts#TOC-Stop-inlining-constructors-and-destructors. The Element class is used in inheritence and has non-POD data members. The Element constructor is thus non-trivial. This reduces release binary size by ~12Kb. I saw no impact on the Dromaeo score: http://dromaeo.com/?id=222265,222266 R=eseidel@chromium.org Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=175213