Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(69)

Issue 309593002: Cache sandbox tokens (Closed)

Created:
6 years, 6 months ago by jschuh
Modified:
6 years, 6 months ago
Reviewers:
cpu_(ooo_6.6-7.5)
CC:
chromium-reviews
Visibility:
Public.

Description

This will make process launch faster and may prevent the LSASS hangs we've seen on XP/Vista. BUG=347825 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=275334

Patch Set 1 #

Patch Set 2 : checkpoint #

Patch Set 3 : initial #

Patch Set 4 : formatting #

Patch Set 5 : token scoping #

Total comments: 4

Patch Set 6 : cleanup #

Patch Set 7 : docs #

Unified diffs Side-by-side diffs Delta from patch set Stats (+94 lines, -8 lines) Patch
M sandbox/win/src/broker_services.h View 1 2 3 4 5 2 chunks +4 lines, -0 lines 0 comments Download
M sandbox/win/src/broker_services.cc View 1 2 3 4 5 6 4 chunks +61 lines, -4 lines 0 comments Download
M sandbox/win/src/sandbox_policy.h View 1 2 3 4 5 3 chunks +10 lines, -1 line 0 comments Download
M sandbox/win/src/sandbox_policy_base.h View 1 2 3 4 5 3 chunks +4 lines, -1 line 0 comments Download
M sandbox/win/src/sandbox_policy_base.cc View 1 2 3 4 5 3 chunks +13 lines, -1 line 0 comments Download
M sandbox/win/src/security_level.h View 1 chunk +2 lines, -1 line 0 comments Download

Messages

Total messages: 8 (0 generated)
jschuh
ptal
6 years, 6 months ago (2014-06-03 23:45:31 UTC) #1
cpu_(ooo_6.6-7.5)
looks reasonable https://codereview.chromium.org/309593002/diff/70001/sandbox/win/src/broker_services.cc File sandbox/win/src/broker_services.cc (right): https://codereview.chromium.org/309593002/diff/70001/sandbox/win/src/broker_services.cc#newcode320 sandbox/win/src/broker_services.cc:320: (policy_base->GetIntegrityLevel() * 8 * 8 * 8); ...
6 years, 6 months ago (2014-06-04 00:29:27 UTC) #2
jschuh
ptal https://codereview.chromium.org/309593002/diff/70001/sandbox/win/src/broker_services.cc File sandbox/win/src/broker_services.cc (right): https://codereview.chromium.org/309593002/diff/70001/sandbox/win/src/broker_services.cc#newcode320 sandbox/win/src/broker_services.cc:320: (policy_base->GetIntegrityLevel() * 8 * 8 * 8); On ...
6 years, 6 months ago (2014-06-04 04:00:59 UTC) #3
cpu_(ooo_6.6-7.5)
lgtm
6 years, 6 months ago (2014-06-05 18:29:53 UTC) #4
jschuh
The CQ bit was checked by jschuh@chromium.org
6 years, 6 months ago (2014-06-05 20:05:37 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/jschuh@chromium.org/309593002/150001
6 years, 6 months ago (2014-06-05 20:07:21 UTC) #6
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: mac_chromium_rel on tryserver.chromium ...
6 years, 6 months ago (2014-06-06 00:05:33 UTC) #7
commit-bot: I haz the power
6 years, 6 months ago (2014-06-06 05:13:00 UTC) #8
Message was sent while issue was closed.
Change committed as 275334

Powered by Google App Engine
This is Rietveld 408576698