Issue 309573007: Add content/child to the GN build.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 309573007: Add content/child to the GN build. (Closed)

Created:
6 years, 6 months ago by brettw

Modified:
6 years, 6 months ago

Reviewers:
scottmg

CC:
chromium-reviews, darin-cc_chromium.org, jam

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

Add content/child to the GN build. BUG= R=scottmg@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=274276

Patch Set 2 : addc child.gni #

Patch Set 3 : Fix Android #

Created: 6 years, 6 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+123 lines, -10 lines)			Patch
M	BUILD.gn	View	1	1 chunk	+1 line, -0 lines	0 comments	Download
A	content/child/BUILD.gn	View	1 2	1 chunk	+114 lines, -0 lines	0 comments	Download
A +	content/child/child.gni	View	1	1 chunk	+4 lines, -4 lines	0 comments	Download
A +	content/public/child/BUILD.gn	View	1	2 chunks	+4 lines, -6 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

scottmg

lgtm https://codereview.chromium.org/309573007/diff/1/content/child/BUILD.gn File content/child/BUILD.gn (right): https://codereview.chromium.org/309573007/diff/1/content/child/BUILD.gn#newcode46 content/child/BUILD.gn:46: "npapi/plugin_host.cc", this is one where the pattern actually ...

6 years, 6 months ago (2014-06-02 16:12:16 UTC) #2

brettw

https://codereview.chromium.org/309573007/diff/1/content/child/BUILD.gn File content/child/BUILD.gn (right): https://codereview.chromium.org/309573007/diff/1/content/child/BUILD.gn#newcode111 content/child/BUILD.gn:111: } On 2014/06/02 16:12:16, scottmg wrote: > seems like ...

6 years, 6 months ago (2014-06-02 16:50:31 UTC) #3