Issue 309573002: Add test that inherited properties are preserved for synthetic change records

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 309573002: Add test that inherited properties are preserved for synthetic change records

Created:
6 years, 6 months ago by rafaelw

Modified:
6 years, 6 months ago

Reviewers:
rossberg

CC:
v8-dev, adamk

Base URL:
https://v8.googlecode.com/svn/branches/bleeding_edge

Visibility:
Public.

More Reviews

Description

Add test that inherited properties are preserved for synthetic change records R=rossberg BUG=

Patch Set 2 : cr comments #

Created: 6 years, 6 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+25 lines, -0 lines)			Patch
	M	test/mjsunit/es7/object-observe.js	View	1	1 chunk	+25 lines, -0 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

rossberg

https://codereview.chromium.org/309573002/diff/1/test/mjsunit/es7/object-observe.js File test/mjsunit/es7/object-observe.js (right): https://codereview.chromium.org/309573002/diff/1/test/mjsunit/es7/object-observe.js#newcode225 test/mjsunit/es7/object-observe.js:225: var rec2 = Object.create(proto); I don't understand, this is ...

6 years, 6 months ago (2014-06-02 09:14:14 UTC) #2

rafaelw

6 years, 6 months ago (2014-06-02 18:32:20 UTC) #3

rossberg

6 years, 6 months ago (2014-06-03 10:41:56 UTC) #4

lgtm

https://codereview.chromium.org/309573002/diff/1/test/mjsunit/es7/object-obse...
File test/mjsunit/es7/object-observe.js (right):

https://codereview.chromium.org/309573002/diff/1/test/mjsunit/es7/object-obse...
test/mjsunit/es7/object-observe.js:225: var rec2 = Object.create(proto);
On 2014/06/02 18:32:20, rafaelw wrote:
> removed.
> 
> On 2014/06/02 09:14:15, rossberg wrote:
> > I don't understand, this is never used.

Ah, OK. I wasn't sure if the intention was to use it in place of rec in the
lines that followed.

Expand Messages | Collapse Messages

Issue 309573002: Add test that inherited properties are preserved for synthetic change records

Description

Patch Set 1 #

Patch Set 2 : cr comments #

Messages