Enable policy support for registering protocol handler.

components/policy/core/browser/configuration_policy_handler.h

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef COMPONENTS_POLICY_CORE_BROWSER_CONFIGURATION_POLICY_HANDLER_H_
 #define COMPONENTS_POLICY_CORE_BROWSER_CONFIGURATION_POLICY_HANDLER_H_
 
 #include <string>
 #include <vector>
 
@@ skipping 255 matching lines @@
                         scoped_ptr<base::Value>* output);
 
  private:
   const char* policy_name_;
   Schema schema_;
   SchemaOnErrorStrategy strategy_;
 
   DISALLOW_COPY_AND_ASSIGN(SchemaValidatingPolicyHandler);
 };
 
+// Maps policy to pref like SimplePolicyHandler while ensuring that the value
+// set matches the schema. |schema| is the schema used for policies, and
+// |strategy| is the strategy used for schema validation errors. The
+// |allow_recommended| and |allow_mandatory| flags indicate the levels at which
+// the policy can be set. A value set at an unsupported level will be ignored.
+class POLICY_EXPORT SimpleSchemaValidatingPolicyHandler
+    : public SchemaValidatingPolicyHandler {
+ public:
+  SimpleSchemaValidatingPolicyHandler(const char* policy_name,

[bartfab (slow), 2014/06/11 10:08:44]

This constructor is not used anywhere.

[Andrew T Wilson (Slow), 2014/06/11 12:32:55]

If you are going to leave this constructor in place, document what the defaults
for allow_recommended/mandatory will be.

[kaliamoorthi, 2014/06/13 13:22:27]

I have removed it.

[kaliamoorthi, 2014/06/13 13:22:27]

I have removed it.

+                                      const char* pref_path,
+                                      Schema schema,
+                                      SchemaOnErrorStrategy strategy);
+  SimpleSchemaValidatingPolicyHandler(const char* policy_name,
+                                      const char* pref_path,
+                                      Schema schema,
+                                      SchemaOnErrorStrategy strategy,
+                                      bool allow_recommended,

[Andrew T Wilson (Slow), 2014/06/11 12:32:55]

nit: I don't like passing raw bools around to constructors and other APIs,
because you end up with a constructor that looks like Object(x, y, z, true,
false) with no understanding of what true/false means in that context.

Consider using something like:

enum MandatoryAllowed {
  MANDATORY_ALLOWED,
  MANDATORY_PROHIBITED
}

Then your constructor looks like:

Object(a, b, c, REQUIRED_ALLOWED, MANDATORY_PROHIBITED)

which is much more readable.

[kaliamoorthi, 2014/06/13 13:22:27]

Done.

+                                      bool allow_mandatory);
+  virtual ~SimpleSchemaValidatingPolicyHandler();
+
+  // ConfigurationPolicyHandler:
+  virtual bool CheckPolicySettings(const PolicyMap& policies,
+                                   PolicyErrorMap* errors) OVERRIDE;
+  virtual void ApplyPolicySettings(const PolicyMap& policies,
+                                   PrefValueMap* prefs) OVERRIDE;
+
+ private:
+  const char* pref_path_;
+  const bool allow_recommended_;
+  const bool allow_mandatory_;
+
+  DISALLOW_COPY_AND_ASSIGN(SimpleSchemaValidatingPolicyHandler);
+};
+
 // A policy handler to deprecate multiple legacy policies with a new one.
 // This handler will completely ignore any of legacy policy values if the new
 // one is set.
 class POLICY_EXPORT LegacyPoliciesDeprecatingPolicyHandler
     : public ConfigurationPolicyHandler {
  public:
   LegacyPoliciesDeprecatingPolicyHandler(
       ScopedVector<ConfigurationPolicyHandler> legacy_policy_handlers,
       scoped_ptr<SchemaValidatingPolicyHandler> new_policy_handler);
   virtual ~LegacyPoliciesDeprecatingPolicyHandler();
 
   // ConfigurationPolicyHandler:
   virtual bool CheckPolicySettings(const PolicyMap& policies,
                                    PolicyErrorMap* errors) OVERRIDE;
   virtual void ApplyPolicySettings(const PolicyMap& policies,
                                    PrefValueMap* prefs) OVERRIDE;
 
  private:
   ScopedVector<ConfigurationPolicyHandler> legacy_policy_handlers_;
   scoped_ptr<SchemaValidatingPolicyHandler> new_policy_handler_;
 
   DISALLOW_COPY_AND_ASSIGN(LegacyPoliciesDeprecatingPolicyHandler);
 };
 
 }  // namespace policy
 
 #endif  // COMPONENTS_POLICY_CORE_BROWSER_CONFIGURATION_POLICY_HANDLER_H_