Enable policy support for registering protocol handler.

components/policy/core/browser/configuration_policy_handler_unittest.cc

 // Copyright (c) 2014 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "base/callback.h"
 #include "base/json/json_reader.h"
 #include "base/memory/scoped_ptr.h"
 #include "base/prefs/pref_value_map.h"
 #include "base/values.h"
 #include "components/policy/core/browser/configuration_policy_handler.h"
 #include "components/policy/core/browser/policy_error_map.h"
 #include "components/policy/core/common/policy_map.h"
 #include "components/policy/core/common/schema.h"
 #include "testing/gtest/include/gtest/gtest.h"
 
 namespace policy {
 
 namespace {
 
 StringToIntEnumListPolicyHandler::MappingEntry kTestTypeMap[] = {
   { "one", 1 },
   { "two", 2 },
 };
 
 const char kTestPolicy[] = "unit_test.test_policy";
 const char kTestPref[] = "unit_test.test_pref";
 
-class SimpleSchemaValidatingPolicyHandler
-    : public SchemaValidatingPolicyHandler {
+class TestSchemaValidatingPolicyHandler : public SchemaValidatingPolicyHandler {
  public:
-  SimpleSchemaValidatingPolicyHandler(const Schema& schema,
-                                      SchemaOnErrorStrategy strategy)
+  TestSchemaValidatingPolicyHandler(const Schema& schema,
+                                    SchemaOnErrorStrategy strategy)
       : SchemaValidatingPolicyHandler("PolicyForTesting", schema, strategy) {}
-  virtual ~SimpleSchemaValidatingPolicyHandler() {}
+  virtual ~TestSchemaValidatingPolicyHandler() {}
 
   virtual void ApplyPolicySettings(const policy::PolicyMap&,
                                    PrefValueMap*) OVERRIDE {
   }
 
   bool CheckAndGetValueForTest(const PolicyMap& policies,
                                scoped_ptr<base::Value>* value) {
     return SchemaValidatingPolicyHandler::CheckAndGetValue(
         policies, NULL, value);
   }
@@ skipping 491 matching lines @@
       kPolicyMapJson, base::JSON_PARSE_RFC, NULL, &error));
   ASSERT_TRUE(policy_map_value) << error;
 
   const base::DictionaryValue* policy_map_dict = NULL;
   ASSERT_TRUE(policy_map_value->GetAsDictionary(&policy_map_dict));
 
   PolicyMap policy_map;
   policy_map.LoadFrom(
       policy_map_dict, POLICY_LEVEL_RECOMMENDED, POLICY_SCOPE_USER);
 
-  SimpleSchemaValidatingPolicyHandler handler(schema, SCHEMA_ALLOW_INVALID);
+  TestSchemaValidatingPolicyHandler handler(schema, SCHEMA_ALLOW_INVALID);
   scoped_ptr<base::Value> output_value;
   ASSERT_TRUE(handler.CheckAndGetValueForTest(policy_map, &output_value));
   ASSERT_TRUE(output_value);
 
   base::DictionaryValue* dict = NULL;
   ASSERT_TRUE(output_value->GetAsDictionary(&dict));
 
   // Test that CheckAndGetValue() actually dropped invalid properties.
   int int_value = -1;
   EXPECT_TRUE(dict->GetInteger("OneToThree", &int_value));
   EXPECT_EQ(2, int_value);
   EXPECT_FALSE(dict->HasKey("Colors"));
 }
 
+TEST(SimpleSchemaValidatingPolicyHandlerTest, CompleteTest) {

[bartfab (slow), 2014/06/06 12:01:57]

I think the test name |CheckAndGetValue| that you based this on is more
appropriate. The things you test here are checking the value and getting it.

[kaliamoorthi, 2014/06/10 17:14:27]

Done.

+  const char policy_name[] = "PolicyForTesting";
+  static const char kSchemaJson[] =

[bartfab (slow), 2014/06/06 12:01:57]

Nit: It looks like this constant is shared with
SchemaValidatingPolicyHandlerTest.CheckAndGetValue. It should be defined at the
top of the file instead of copy & pasting.

[kaliamoorthi, 2014/06/10 17:14:27]

We discussed

+      "{"
+      "  \"type\": \"object\","
+      "  \"properties\": {"
+      "    \"PolicyForTesting\": {"
+      "      \"type\": \"object\","
+      "      \"properties\": {"
+      "        \"OneToThree\": {"
+      "          \"type\": \"integer\","
+      "          \"minimum\": 1,"
+      "          \"maximum\": 3"
+      "        },"
+      "        \"Colors\": {"
+      "          \"type\": \"string\","
+      "          \"enum\": [ \"Red\", \"Green\", \"Blue\" ]"
+      "        }"
+      "      }"
+      "    }"
+      "  }"
+      "}";
+  std::string error;
+  Schema schema = Schema::Parse(kSchemaJson, &error);
+  ASSERT_TRUE(schema.valid()) << error;
+
+  static const char kPolicyMapJson[] =

[bartfab (slow), 2014/06/06 12:01:57]

Nit: It looks like this constant is shared with
SchemaValidatingPolicyHandlerTest.CheckAndGetValue. It should be defined at the
top of the file instead of copy & pasting.

[kaliamoorthi, 2014/06/10 17:14:27]

We discussed

+      "{"
+      "  \"PolicyForTesting\": {"
+      "    \"OneToThree\": 2,"
+      "    \"Colors\": \"Green\""
+      "  }"
+      "}";
+  scoped_ptr<base::Value> policy_map_value(base::JSONReader::ReadAndReturnError(
+      kPolicyMapJson, base::JSON_PARSE_RFC, NULL, &error));
+  ASSERT_TRUE(policy_map_value) << error;
+
+  const base::DictionaryValue* policy_map_dict = NULL;
+  ASSERT_TRUE(policy_map_value->GetAsDictionary(&policy_map_dict));
+
+  PolicyMap policy_map_recommended;
+  policy_map_recommended.LoadFrom(
+      policy_map_dict, POLICY_LEVEL_RECOMMENDED, POLICY_SCOPE_USER);
+
+  PolicyMap policy_map_mandatory;
+  policy_map_mandatory.LoadFrom(
+      policy_map_dict, POLICY_LEVEL_MANDATORY, POLICY_SCOPE_USER);
+
+  SimpleSchemaValidatingPolicyHandler handler_all(
+      policy_name, kTestPref, schema, SCHEMA_STRICT, true, true);
+
+  SimpleSchemaValidatingPolicyHandler handler_recommended(
+      policy_name, kTestPref, schema, SCHEMA_STRICT, true, false);
+
+  SimpleSchemaValidatingPolicyHandler handler_mandatory(
+      policy_name, kTestPref, schema, SCHEMA_STRICT, false, true);
+
+  SimpleSchemaValidatingPolicyHandler handler_none(
+      policy_name, kTestPref, schema, SCHEMA_STRICT, false, false);
+
+  const base::Value* value_expected_in_pref;
+  policy_map_dict->Get(policy_name, &value_expected_in_pref);
+
+  PolicyErrorMap errors;
+  PrefValueMap prefs;
+  base::Value* value_set_in_pref;
+
+  EXPECT_TRUE(handler_all.CheckPolicySettings(policy_map_mandatory, &errors));
+  prefs.Clear();
+  handler_all.ApplyPolicySettings(policy_map_mandatory, &prefs);
+  EXPECT_TRUE(prefs.GetValue(kTestPref, &value_set_in_pref));
+  EXPECT_TRUE(value_expected_in_pref->Equals(value_set_in_pref));
+
+  EXPECT_FALSE(
+      handler_recommended.CheckPolicySettings(policy_map_mandatory, &errors));
+
+  EXPECT_TRUE(
+      handler_mandatory.CheckPolicySettings(policy_map_mandatory, &errors));
+  prefs.Clear();
+  handler_mandatory.ApplyPolicySettings(policy_map_mandatory, &prefs);
+  EXPECT_TRUE(prefs.GetValue(kTestPref, &value_set_in_pref));
+  EXPECT_TRUE(value_expected_in_pref->Equals(value_set_in_pref));
+
+  EXPECT_FALSE(handler_none.CheckPolicySettings(policy_map_mandatory, &errors));
+
+  EXPECT_TRUE(handler_all.CheckPolicySettings(policy_map_recommended, &errors));
+  prefs.Clear();
+  handler_all.ApplyPolicySettings(policy_map_mandatory, &prefs);
+  EXPECT_TRUE(prefs.GetValue(kTestPref, &value_set_in_pref));
+  EXPECT_TRUE(value_expected_in_pref->Equals(value_set_in_pref));
+
+  EXPECT_FALSE(
+      handler_mandatory.CheckPolicySettings(policy_map_recommended, &errors));
+
+  EXPECT_TRUE(
+      handler_recommended.CheckPolicySettings(policy_map_recommended, &errors));
+  prefs.Clear();
+  handler_recommended.ApplyPolicySettings(policy_map_mandatory, &prefs);
+  EXPECT_TRUE(prefs.GetValue(kTestPref, &value_set_in_pref));
+  EXPECT_TRUE(value_expected_in_pref->Equals(value_set_in_pref));
+
+  EXPECT_FALSE(
+      handler_none.CheckPolicySettings(policy_map_recommended, &errors));
+}
+
 }  // namespace policy