Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(754)

Issue 309553010: Revert of Fix legacy dummy window visibility inheritance. RenderWidgetHostViewAura may be shown(::S… (Closed)

Created:
6 years, 6 months ago by tapted
Modified:
6 years, 6 months ago
CC:
chromium-reviews, yusukes+watch_chromium.org, yukishiino+watch_chromium.org, jam, penghuang+watch_chromium.org, sievers+watch_chromium.org, jbauman+watch_chromium.org, nona+watch_chromium.org, darin-cc_chromium.org, kalyank, piman+watch_chromium.org, danakj+watch_chromium.org, James Su, miu+watch_chromium.org, chrome-apps-syd-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Visibility:
Public.

Description

Revert of Fix legacy dummy window visibility inheritance. RenderWidgetHostViewAura may be shown(::Show()) bef… (https://codereview.chromium.org/272173002/) Reason for revert: Regression: makes frameless packaged app windows unmovable in Aero. Confirmed with local git revert. BUG=374681 TBR=ben@chromium.org Original issue's description: > Fix legacy dummy window visibility inheritance. RenderWidgetHostViewAura may be shown(::Show()) before legacy window creation, in such case dummy window was later created hidden which leads to wrong behaviour. E.g. NPAPI Flash in windowless mode tracks associated window visibility and slows down draw invalidation. > > R=ben@chromium.org > BUG= > > Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=270739 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=274172

Patch Set 1 #

Patch Set 2 : rebase to master #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -5 lines) Patch
M AUTHORS View 1 1 chunk +0 lines, -1 line 0 comments Download
M content/browser/renderer_host/render_widget_host_view_aura.cc View 1 1 chunk +0 lines, -4 lines 0 comments Download

Messages

Total messages: 10 (0 generated)
tapted
Created Revert of Fix legacy dummy window visibility inheritance. RenderWidgetHostViewAura may be shown(::Show()) bef…
6 years, 6 months ago (2014-06-02 01:10:00 UTC) #1
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 6 months ago (2014-06-02 01:10:25 UTC) #2
tapted
The CQ bit was checked by tapted@chromium.org
6 years, 6 months ago (2014-06-02 01:14:57 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/tapted@chromium.org/309553010/1
6 years, 6 months ago (2014-06-02 01:15:25 UTC) #4
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 6 months ago (2014-06-02 01:16:06 UTC) #5
commit-bot: I haz the power
Failed to apply patch for content/browser/renderer_host/render_widget_host_view_aura.cc: While running patch -p1 --forward --force --no-backup-if-mismatch; patching file ...
6 years, 6 months ago (2014-06-02 01:16:06 UTC) #6
tapted
The CQ bit was checked by tapted@chromium.org
6 years, 6 months ago (2014-06-02 01:46:07 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/tapted@chromium.org/309553010/50001
6 years, 6 months ago (2014-06-02 01:46:24 UTC) #8
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: linux_chromium_rel on tryserver.chromium ...
6 years, 6 months ago (2014-06-02 03:31:38 UTC) #9
commit-bot: I haz the power
6 years, 6 months ago (2014-06-02 05:48:52 UTC) #10
Message was sent while issue was closed.
Change committed as 274172

Powered by Google App Engine
This is Rietveld 408576698