Issue 309553008: Add command argument to perf test_runner.py help command

Issue 309553008: Add command argument to perf test_runner.py help command (Closed)

Created:
6 years, 6 months ago by alancutter (OOO until 2018)

Modified:
6 years, 6 months ago

Reviewers:
dtu

CC:
chromium-reviews, telemetry+watch_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

Add command argument to perf test_runner help command This patch adds an optional argument to "tools/perf/run_benchmark help" to show help for a specific test_runner.py command. Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=278040

Patch Set 1 #

Patch Set 2 : Show all commands if startswith conflict present: run_benchmark help '' #

Total comments: 3

Patch Set 3 : Review changes #

Created: 6 years, 6 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+20 lines, -4 lines)			Patch
	M	tools/telemetry/telemetry/core/command_line.py	View	1 2	1 chunk	+2 lines, -1 line	0 comments	Download
	M	tools/telemetry/telemetry/test_runner.py	View	1 2	3 chunks	+18 lines, -3 lines	0 comments	Download

Messages

Total messages: 5 (0 generated)

Expand Messages | Collapse Messages

dtu

Thanks! Just nits. lgtm https://chromiumcodereview.appspot.com/309553008/diff/20001/tools/telemetry/telemetry/test_runner.py File tools/telemetry/telemetry/test_runner.py (right): https://chromiumcodereview.appspot.com/309553008/diff/20001/tools/telemetry/telemetry/test_runner.py#newcode47 tools/telemetry/telemetry/test_runner.py:47: description=cls.Description()) Move to parent class ...

6 years, 6 months ago (2014-06-04 23:43:02 UTC) #2

alancutter (OOO until 2018)

The CQ bit was checked by alancutter@chromium.org

6 years, 6 months ago (2014-06-18 07:05:18 UTC) #3

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/alancutter@chromium.org/309553008/40001

6 years, 6 months ago (2014-06-18 07:08:10 UTC) #4

Message was sent while issue was closed.

Change committed as 278040

Expand Messages | Collapse Messages