Source/core/page/EventHandler.cpp - Issue 309553007: Adding support for Text Selection on Disabled and Readonly input elements in Android

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/core/page/EventHandler.cpp

Issue 309553007: Adding support for Text Selection on Disabled and Readonly input elements in Android (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Created 6 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« LayoutTests/editing/selection/readonly-disabled-text-selection.html ('K') | « LayoutTests/platform/android/editing/selection/readonly-disabled-text-selection-expected.txt ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: Source/core/page/EventHandler.cpp

diff --git a/Source/core/page/EventHandler.cpp b/Source/core/page/EventHandler.cpp

index d40aac41a1ab9ee03ff5328023c6b9d29c0cc583..f8675f660fd0c4dd7deaa695a3999d559c728490 100644

--- a/Source/core/page/EventHandler.cpp

+++ b/Source/core/page/EventHandler.cpp

@@ -2318,7 +2318,7 @@ bool EventHandler::handleGestureLongPress(const GestureEventWithHitTestResults&

IntPoint hitTestPoint = m_frame->view()->windowToContents(gestureEvent.position());

HitTestResult result = hitTestResultAtPoint(hitTestPoint);

Node* innerNode = result.innerNode();

- if (!result.isLiveLink() && innerNode && (innerNode->isContentEditable() || innerNode->isTextNode())) {

+ if (!result.isLiveLink() && innerNode && (innerNode->isContentEditable() || innerNode->isTextNode() || innerNode->canStartSelection())) {

selectClosestWordFromHitTestResult(result, DontAppendTrailingWhitespace);

if (m_frame->selection().isRange()) {

focusDocumentView();