Adding support for Text Selection on Disabled and Readonly input elements in Android

Text selection should happen on Disabled and Readonly elements when do
long press on those elements in Android for allowing user to Copy.

HitTest is coming as the layered parent node, so text selection is
not happening. This change takes care of processing text selection in
case of disabled/readonly elements.

Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=184746

[AKVT, 2014-05-31 11:08:26]

PTAL this change

[AKVT, 2014-05-31 11:11:19]

PTAL

[hayato, 2014-06-02 04:31:43]

Could we have a test?

I'd like to know what issue this patch would fix clearly.

[AKVT, 2014-06-02 05:29:19]

On 2014/06/02 04:31:43, hayato wrote:
> Could we have a test?
> 
> I'd like to know what issue this patch would fix clearly.

@hayato This change will let text selection happen on disabled/readonly
input/textarea elements when we do long press on such elements. Currently this
is not supported in mobile versions of Chrome.

[eseidel, 2014-06-02 05:35:31]

A test is definitely required (or explaination of why such is impossible). 
window.eventSender may be of help.

[AKVT, 2014-06-02 05:39:59]

On 2014/06/02 05:35:31, eseidel wrote:
> A test is definitely required (or explaination of why such is impossible). 
> window.eventSender may be of help.

I will add layout test case soon. Actually I am new to layout test case writings
and execution. So taking time to adapt to it. By the way could you please help
me to simulate long press using eventSender object ?

[hayato, 2014-06-02 05:43:28]

On 2014/06/02 05:29:19, AJITH KUMAR V wrote:
> On 2014/06/02 04:31:43, hayato wrote:
> > Could we have a test?
> > 
> > I'd like to know what issue this patch would fix clearly.
> 
> @hayato This change will let text selection happen on disabled/readonly
> input/textarea elements when we do long press on such elements. Currently this
> is not supported in mobile versions of Chrome.

I am not sure what is desired behavior on long pressing.
I think you should include a bug number or a pointer to the discussion in this
CL so that we can know this CL implements the desired behavior or not.

Also, could you have a layout test for this new behavior?

[AKVT, 2014-06-02 06:06:57]

On 2014/06/02 05:43:28, hayato wrote:
> On 2014/06/02 05:29:19, AJITH KUMAR V wrote:
> > On 2014/06/02 04:31:43, hayato wrote:
> > > Could we have a test?
> > > 
> > > I'd like to know what issue this patch would fix clearly.
> > 
> > @hayato This change will let text selection happen on disabled/readonly
> > input/textarea elements when we do long press on such elements. Currently
this
> > is not supported in mobile versions of Chrome.
> 
> I am not sure what is desired behavior on long pressing.
> I think you should include a bug number or a pointer to the discussion in this
> CL so that we can know this CL implements the desired behavior or not.
> 
> Also, could you have a layout test for this new behavior?

When we do long press on disabled/readonly input field, currently paste popup,
is coming, which itself is a bug, and I am addressing it with
https://codereview.chromium.org/246203004/.
Other than this copy should allow from readonly/disabled fields because we are
blocking only editing part. If required I will raise a bug for discussion.

[esprehn, 2014-06-05 01:13:53]

Can you write a test?

[AKVT, 2014-06-05 05:45:17]

On 2014/06/05 01:13:53, esprehn wrote:
> Can you write a test?

I am writing the layout test case, and will upload soon.

[AKVT, 2014-10-16 19:27:02]

ajith.v@samsung.com changed reviewers:
+ yutak@chromium.org
- hayato@chromium.org

[AKVT, 2014-10-16 19:27:37]

ajith.v@samsung.com changed reviewers:
+ yosin@chromium.org

[AKVT, 2014-10-16 19:28:41]

ajith.v@samsung.com changed reviewers:
- yutak@chromium.org

[AKVT, 2014-10-16 19:31:39]

@esprehn PTAL. Sorry for the delay. I became comfortable in writing layout test
cases recently. Thanks

[AKVT, 2014-10-17 02:43:42]

ajith.v@samsung.com changed reviewers:
+ hayato@chromium.org
- yosin@chromium.org

[AKVT, 2014-10-17 21:32:02]

@esprehn, since this change is only applicable to android, other platform tests
are failing. Can I keep the HTML file inside LayoutTests/platform/android
folder, so that it won't be triggered for other platforms ? Please share your
thoughts on this.

[esprehn, 2014-10-17 21:55:55]

Please remove empty BUG= lines. You should skip the test in NeverFixTests on all
platforms it can't run on.

https://codereview.chromium.org/309553007/diff/40001/LayoutTests/editing/sele...
File LayoutTests/editing/selection/readonly-disabled-text-selection.html
(right):

https://codereview.chromium.org/309553007/diff/40001/LayoutTests/editing/sele...
LayoutTests/editing/selection/readonly-disabled-text-selection.html:3: <head>
Leave out html, head and body.

https://codereview.chromium.org/309553007/diff/40001/LayoutTests/editing/sele...
LayoutTests/editing/selection/readonly-disabled-text-selection.html:6: function
test() {
onload = function() {

https://codereview.chromium.org/309553007/diff/40001/LayoutTests/editing/sele...
LayoutTests/editing/selection/readonly-disabled-text-selection.html:7:
jsTestAsync = true;
remove.

https://codereview.chromium.org/309553007/diff/40001/LayoutTests/editing/sele...
LayoutTests/editing/selection/readonly-disabled-text-selection.html:9:
testRunner.dumpAsText();
remove, js-test does this for you.

https://codereview.chromium.org/309553007/diff/40001/LayoutTests/editing/sele...
LayoutTests/editing/selection/readonly-disabled-text-selection.html:11: if
(!window.eventSender)
combine with the check below.

https://codereview.chromium.org/309553007/diff/40001/LayoutTests/editing/sele...
LayoutTests/editing/selection/readonly-disabled-text-selection.html:14: if
(!window.eventSender.gestureLongPress) {
Why doesn't this work on Chrome OS with touch or any other touch enabled
platform? It seems like eventSender should support this on all platforms...

also use 

if (!window.eventSender || !eventSender.gestureLongPress) {

https://codereview.chromium.org/309553007/diff/40001/LayoutTests/editing/sele...
LayoutTests/editing/selection/readonly-disabled-text-selection.html:21: //
Normal Text
these comments aren't adding value, they're the same as the string, just remove
them.

https://codereview.chromium.org/309553007/diff/40001/LayoutTests/editing/sele...
LayoutTests/editing/selection/readonly-disabled-text-selection.html:45:
finishJSTest();
This test doesn't need to be async, you're just waiting for load which all tests
do already.

https://codereview.chromium.org/309553007/diff/40001/LayoutTests/editing/sele...
LayoutTests/editing/selection/readonly-disabled-text-selection.html:58: if
(selectedText == elementValue) {
Use shouldBeEqualToString(), don't reinvent it yourself.

https://codereview.chromium.org/309553007/diff/40001/LayoutTests/editing/sele...
LayoutTests/editing/selection/readonly-disabled-text-selection.html:67: <body
onload="test();">
remove.

[AKVT, 2014-10-20 19:50:02]

@esprehn PTAL

https://codereview.chromium.org/309553007/diff/40001/LayoutTests/editing/sele...
File LayoutTests/editing/selection/readonly-disabled-text-selection.html
(right):

https://codereview.chromium.org/309553007/diff/40001/LayoutTests/editing/sele...
LayoutTests/editing/selection/readonly-disabled-text-selection.html:3: <head>
On 2014/10/17 21:55:54, esprehn wrote:
> Leave out html, head and body.

Done. Thanks you

https://codereview.chromium.org/309553007/diff/40001/LayoutTests/editing/sele...
LayoutTests/editing/selection/readonly-disabled-text-selection.html:6: function
test() {
On 2014/10/17 21:55:55, esprehn wrote:
> onload = function() {

Done. Thanks

https://codereview.chromium.org/309553007/diff/40001/LayoutTests/editing/sele...
LayoutTests/editing/selection/readonly-disabled-text-selection.html:7:
jsTestAsync = true;
On 2014/10/17 21:55:54, esprehn wrote:
> remove.

Done.

https://codereview.chromium.org/309553007/diff/40001/LayoutTests/editing/sele...
LayoutTests/editing/selection/readonly-disabled-text-selection.html:9:
testRunner.dumpAsText();
On 2014/10/17 21:55:55, esprehn wrote:
> remove, js-test does this for you.

Done. Thanks

https://codereview.chromium.org/309553007/diff/40001/LayoutTests/editing/sele...
LayoutTests/editing/selection/readonly-disabled-text-selection.html:11: if
(!window.eventSender)
On 2014/10/17 21:55:54, esprehn wrote:
> combine with the check below.

Done.

https://codereview.chromium.org/309553007/diff/40001/LayoutTests/editing/sele...
LayoutTests/editing/selection/readonly-disabled-text-selection.html:14: if
(!window.eventSender.gestureLongPress) {
On 2014/10/17 21:55:54, esprehn wrote:
> Why doesn't this work on Chrome OS with touch or any other touch enabled
> platform? It seems like eventSender should support this on all platforms...
> 
> also use 
> 
> if (!window.eventSender || !eventSender.gestureLongPress) {

Done. Thank you

https://codereview.chromium.org/309553007/diff/40001/LayoutTests/editing/sele...
LayoutTests/editing/selection/readonly-disabled-text-selection.html:21: //
Normal Text
On 2014/10/17 21:55:54, esprehn wrote:
> these comments aren't adding value, they're the same as the string, just
remove
> them.

Done.

https://codereview.chromium.org/309553007/diff/40001/LayoutTests/editing/sele...
LayoutTests/editing/selection/readonly-disabled-text-selection.html:45:
finishJSTest();
On 2014/10/17 21:55:55, esprehn wrote:
> This test doesn't need to be async, you're just waiting for load which all
tests
> do already.

Done.

https://codereview.chromium.org/309553007/diff/40001/LayoutTests/editing/sele...
LayoutTests/editing/selection/readonly-disabled-text-selection.html:58: if
(selectedText == elementValue) {
On 2014/10/17 21:55:54, esprehn wrote:
> Use shouldBeEqualToString(), don't reinvent it yourself.

Done. Thank you

https://codereview.chromium.org/309553007/diff/40001/LayoutTests/editing/sele...
LayoutTests/editing/selection/readonly-disabled-text-selection.html:67: <body
onload="test();">
On 2014/10/17 21:55:54, esprehn wrote:
> remove.

Done.

[AKVT, 2014-10-23 15:55:35]

@esprehn PTAL

[AKVT, 2014-10-27 16:25:48]

@esprehn PTAL. Android shows a build break due to some script issue. Could you
please suggest a better way to tackle Android bot.

[AKVT, 2014-10-28 17:59:27]

@hayato, eseidel & esprehn PTAL

[AKVT, 2014-10-30 17:45:46]

@esprehn & eseidel PTAL this change.

[esprehn, 2014-10-31 17:11:03]

lgtm, thanks for being patient!

[esprehn, 2014-10-31 17:11:40]

esprehn@chromium.org changed reviewers:
+ rbyers@chromium.org

[AKVT, 2014-10-31 17:12:07]

On 2014/10/31 17:11:03, esprehn wrote:
> lgtm, thanks for being patient!

@esprehn Thanks you.

[AKVT, 2014-10-31 17:12:24]

The CQ bit was checked by ajith.v@samsung.com

[esprehn, 2014-10-31 17:12:36]

rbyers@ We probably want this to not be OS(ANDROID) right? Any OS that has a
touch screen should probably do this when making a long press.

[commit-bot: I haz the power, 2014-10-31 17:13:22]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/309553007/120001

[commit-bot: I haz the power, 2014-10-31 18:37:55]

Committed patchset #7 (id:120001) as 184746