Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(346)

Unified Diff: Source/bindings/scripts/v8_methods.py

Issue 309553002: Add ByteString support to IDL bindings (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: Created 6 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: Source/bindings/scripts/v8_methods.py
diff --git a/Source/bindings/scripts/v8_methods.py b/Source/bindings/scripts/v8_methods.py
index adf7d3d90d1968f3ba44667bc313985f6a64d8c1..871d9a97d4e00d516cbc4c6f0c6cb5e7d3c8a4fa 100644
--- a/Source/bindings/scripts/v8_methods.py
+++ b/Source/bindings/scripts/v8_methods.py
@@ -120,7 +120,8 @@ def generate_method(interface, method):
is_check_security_for_frame or
any(argument for argument in arguments
if argument.idl_type.name == 'SerializedScriptValue' or
- argument.idl_type.is_integer_type),
+ argument.idl_type.is_integer_type or
+ argument.idl_type.base_type == 'ByteString'),
Nils Barth (inactive) 2014/06/02 03:20:16 Ditto about .name, in which case this can instead
jsbell 2014/06/03 23:22:36 Done.
'is_call_with_execution_context': has_extended_attribute_value(method, 'CallWith', 'ExecutionContext'),
'is_call_with_script_arguments': is_call_with_script_arguments,
'is_call_with_script_state': is_call_with_script_state,

Powered by Google App Engine
This is Rietveld 408576698