Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(179)

Unified Diff: Source/bindings/scripts/v8_attributes.py

Issue 309553002: Add ByteString support to IDL bindings (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: Created 6 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: Source/bindings/scripts/v8_attributes.py
diff --git a/Source/bindings/scripts/v8_attributes.py b/Source/bindings/scripts/v8_attributes.py
index 6f2496d6a9a283abe98df355e27c16bb0619d1d4..01d583999ca66454497d557b44762e25d27357c0 100644
--- a/Source/bindings/scripts/v8_attributes.py
+++ b/Source/bindings/scripts/v8_attributes.py
@@ -108,7 +108,7 @@ def generate_attribute(interface, attribute):
'has_setter_exception_state':
is_setter_raises_exception or has_type_checking_interface or
has_type_checking_nullable or has_type_checking_unrestricted or
- idl_type.is_integer_type,
+ idl_type.is_integer_type or idl_type.base_type == 'ByteString',
Nils Barth (inactive) 2014/06/02 03:20:16 This should probably be .name instead of .base_typ
jsbell 2014/06/03 23:22:36 Done.
'has_type_checking_interface': has_type_checking_interface,
'has_type_checking_nullable': has_type_checking_nullable,
'has_type_checking_unrestricted': has_type_checking_unrestricted,

Powered by Google App Engine
This is Rietveld 408576698