tools/telemetry/telemetry/web_perf/timeline_based_measurement.py - Issue 309533016: Remove the weak dictionary that maps tab objects to it markers

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: tools/telemetry/telemetry/web_perf/timeline_based_measurement.py

Issue 309533016: Remove the weak dictionary that maps tab objects to it markers (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 6 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: tools/telemetry/telemetry/web_perf/timeline_based_measurement.py

diff --git a/tools/telemetry/telemetry/web_perf/timeline_based_measurement.py b/tools/telemetry/telemetry/web_perf/timeline_based_measurement.py

index cdf66bb160f8dfac5dd8782fb564cf2c1b603bb9..f6fcfd546f4f46da4f14ffcbacddec66e5aad231 100644

--- a/tools/telemetry/telemetry/web_perf/timeline_based_measurement.py

+++ b/tools/telemetry/telemetry/web_perf/timeline_based_measurement.py

@@ -151,7 +151,7 @@ class TimelineBasedMeasurement(page_measurement.PageMeasurement):

logging.error('Cannot open %s. %s' % (trace_file_path, e))

model = model_module.TimelineModel(trace_result)

- renderer_thread = model.GetRendererThreadFromTab(tab)

+ renderer_thread = model.GetRendererThreadFromTabId(tab.id)

meta_metrics = _TimelineBasedMetrics(

model, renderer_thread, self.CreateMetricsForTimelineInteractionRecord)

meta_metrics.AddResults(results)

« no previous file with comments | « tools/telemetry/telemetry/page/actions/action_runner_unittest.py ('k') | no next file » | no next file with comments »