Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(155)

Unified Diff: tools/telemetry/telemetry/core/backends/chrome/tracing_timeline_data.py

Issue 309533016: Remove the weak dictionary that maps tab objects to it markers (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 6 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: tools/telemetry/telemetry/core/backends/chrome/tracing_timeline_data.py
diff --git a/tools/telemetry/telemetry/core/backends/chrome/tracing_timeline_data.py b/tools/telemetry/telemetry/core/backends/chrome/tracing_timeline_data.py
index 11ef3a29f86091ac4fec24da7e2ccedce52b4b6a..3bc140673391c68cf28bdf19a9093f34c6ebfc16 100644
--- a/tools/telemetry/telemetry/core/backends/chrome/tracing_timeline_data.py
+++ b/tools/telemetry/telemetry/core/backends/chrome/tracing_timeline_data.py
@@ -3,36 +3,20 @@
# found in the LICENSE file.
import json
-import weakref
from telemetry.core.timeline_data import TimelineData
class TracingTimelineData(TimelineData):
- def __init__(self, event_data, tab_to_marker_mapping = None):
+ def __init__(self, event_data):
super(TracingTimelineData, self).__init__()
self._event_data = event_data
- if tab_to_marker_mapping == None:
- self._tab_to_marker_mapping = weakref.WeakKeyDictionary()
- else:
- self._tab_to_marker_mapping = tab_to_marker_mapping
def Serialize(self, f):
"""Serializes the trace result to a file-like object"""
- f.write('{"traceEvents":')
- json.dump(self._event_data, f)
- f.write('}')
+ if 'traceEvents' in self._event_data:
+ json.dump(self._event_data, f)
+ else:
+ json.dump({'traceEvents' : self._event_data}, f)
def EventData(self):
return self._event_data
-
- def AugmentTimelineModel(self, timeline):
- for thread in timeline.GetAllThreads():
- if thread.name == 'CrBrowserMain':
- timeline.browser_process = thread.parent
- for key, value in self._tab_to_marker_mapping.iteritems():
- timeline_markers = timeline.FindTimelineMarkers(value)
- assert(len(timeline_markers) == 1)
- assert(timeline_markers[0].start_thread ==
- timeline_markers[0].end_thread)
- renderer_thread = timeline_markers[0].start_thread
- timeline.AddCoreObjectToContainerMapping(key, renderer_thread)

Powered by Google App Engine
This is Rietveld 408576698