tools/perf/measurements/loading_trace.py - Issue 309533016: Remove the weak dictionary that maps tab objects to it markers

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: tools/perf/measurements/loading_trace.py

Issue 309533016: Remove the weak dictionary that maps tab objects to it markers (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 6 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: tools/perf/measurements/loading_trace.py

diff --git a/tools/perf/measurements/loading_trace.py b/tools/perf/measurements/loading_trace.py

index 7ada1dbea8c89c0f08cf22ba593ba35253ceec33..ed48bc06f3bd906f3c9b696d5cc51ccb77508b8e 100644

--- a/tools/perf/measurements/loading_trace.py

+++ b/tools/perf/measurements/loading_trace.py

@@ -31,7 +31,7 @@ class LoadingTrace(page_measurement.PageMeasurement):

loading.LoadingMetric().AddResults(tab, results)

timeline_metric = timeline.LoadTimesTimelineMetric()

renderer_thread = \

- self._timeline_controller.model.GetRendererThreadFromTab(tab)

+ self._timeline_controller.model.GetRendererThreadFromTabId(tab.id)

record = tir_module.TimelineInteractionRecord(

"loading_trace_interaction", 0, float('inf'))

timeline_metric.AddResults(

« no previous file with comments | « no previous file | tools/perf/measurements/smoothness_controller.py » ('j') | no next file with comments »