Issue 309533013: Add traces temporarily to track down flakiness in test.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 309533013: Add traces temporarily to track down flakiness in test. (Closed)

Created:
6 years, 6 months ago by Finnur

Modified:
6 years, 6 months ago

Reviewers:
asargent_no_longer_on_chrome

CC:
chromium-reviews, chromium-apps-reviews_chromium.org, extensions-reviews_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

Add traces temporarily to track down flakiness in test. BUG=379170 TBR=asargent Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=274316

Patch Set 1 #

Created: 6 years, 6 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+25 lines, -8 lines)			Patch
	M	chrome/browser/extensions/extension_toolbar_model.cc	View		3 chunks	+15 lines, -1 line	0 comments	Download
	M	chrome/browser/extensions/extension_toolbar_model_browsertest.cc	View		1 chunk	+10 lines, -7 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

Finnur

Tried running it close to 1000 times on my Linux box and it never fails... ...

6 years, 6 months ago (2014-06-02 20:26:35 UTC) #2

asargent_no_longer_on_chrome

6 years, 6 months ago (2014-06-02 22:49:04 UTC) #4

Message was sent while issue was closed.

lgtm

Random idea for the next time you have a need to do something like this: I
wonder if you could use VLOG instead of LOG(ERROR) and then add a --vmodule=
flag inside a SetupCommandLine override. 

If you try this, let me know if it works!

Expand Messages | Collapse Messages