Issue 309533009: Release execution lock before dispatching interrupt handling.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 309533009: Release execution lock before dispatching interrupt handling. (Closed)

Created:
6 years, 6 months ago by Yang

Modified:
6 years, 6 months ago

Reviewers:
yurys

CC:
v8-dev

Base URL:
https://v8.googlecode.com/svn/branches/bleeding_edge

Visibility:
Public.

More Reviews

Description

Release execution lock before dispatching interrupt handling. R=yurys@chromium.org Committed: https://code.google.com/p/v8/source/detail?r=21605

Patch Set 2 : rebased and addressed comments #

Patch Set 3 : small fix to rebase mistake #

Created: 6 years, 6 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+77 lines, -29 lines)			Patch
M	src/debug.cc	View	1	2 chunks	+5 lines, -0 lines	0 comments	Download
M	src/execution.h	View	1	1 chunk	+1 line, -1 line	0 comments	Download
M	src/execution.cc	View	1 2	2 chunks	+25 lines, -28 lines	0 comments	Download
M	test/cctest/test-debug.cc	View	1	1 chunk	+46 lines, -0 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

yurys

lgtm https://codereview.chromium.org/309533009/diff/1/test/cctest/test-debug.cc File test/cctest/test-debug.cc (right): https://codereview.chromium.org/309533009/diff/1/test/cctest/test-debug.cc#newcode7441 test/cctest/test-debug.cc:7441: terminate_already_fired = true; Can we also check that ...

6 years, 6 months ago (2014-06-02 11:39:11 UTC) #2

Yang

https://codereview.chromium.org/309533009/diff/1/test/cctest/test-debug.cc File test/cctest/test-debug.cc (right): https://codereview.chromium.org/309533009/diff/1/test/cctest/test-debug.cc#newcode7441 test/cctest/test-debug.cc:7441: terminate_already_fired = true; On 2014/06/02 11:39:11, yurys wrote: > ...

6 years, 6 months ago (2014-06-02 11:50:03 UTC) #3