Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(280)

Issue 309533008: Remove fail() method without sourceURL and lineNumber parameter. (Closed)

Created:
6 years, 6 months ago by tyoshino (SeeGerritForStatus)
Modified:
6 years, 6 months ago
Reviewers:
tkent, yhirano
CC:
blink-reviews
Visibility:
Public.

Description

Remove fail() method without sourceURL and lineNumber parameter. We can reduce overloads and also remove using. BUG=none Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=175271

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -5 lines) Patch
M Source/modules/websockets/MainThreadWebSocketChannel.h View 1 chunk +0 lines, -1 line 0 comments Download
M Source/modules/websockets/NewWebSocketChannelImpl.h View 1 chunk +0 lines, -1 line 0 comments Download
M Source/modules/websockets/WebSocket.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/modules/websockets/WebSocketChannel.h View 1 chunk +0 lines, -1 line 0 comments Download
M Source/web/WebSocketImpl.cpp View 2 chunks +2 lines, -1 line 0 comments Download

Messages

Total messages: 8 (0 generated)
tyoshino (SeeGerritForStatus)
6 years, 6 months ago (2014-06-02 08:45:39 UTC) #1
yhirano
lgtm
6 years, 6 months ago (2014-06-02 08:49:02 UTC) #2
tyoshino (SeeGerritForStatus)
The CQ bit was checked by tyoshino@chromium.org
6 years, 6 months ago (2014-06-02 08:50:09 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/tyoshino@chromium.org/309533008/1
6 years, 6 months ago (2014-06-02 08:51:20 UTC) #4
tyoshino (SeeGerritForStatus)
+tkent Kent-san, please take a look for web/ dir.
6 years, 6 months ago (2014-06-02 09:21:36 UTC) #5
tkent
lgtm
6 years, 6 months ago (2014-06-02 09:23:06 UTC) #6
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: blink_presubmit on tryserver.blink ...
6 years, 6 months ago (2014-06-02 10:03:57 UTC) #7
commit-bot: I haz the power
6 years, 6 months ago (2014-06-02 10:45:58 UTC) #8
Message was sent while issue was closed.
Change committed as 175271

Powered by Google App Engine
This is Rietveld 408576698