chrome/browser/media_galleries/media_galleries_scan_result_dialog_controller.cc - Issue 309533007: Refactor PermissionsData pt1

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/media_galleries/media_galleries_scan_result_dialog_controller.cc

Issue 309533007: Refactor PermissionsData pt1 (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Created 6 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/browser/media_galleries/media_galleries_preferences.cc ('K') | « chrome/browser/media_galleries/media_galleries_preferences.cc ('k') | chrome/browser/ui/cocoa/location_bar/location_bar_view_mac.mm » ('j') | chrome/common/extensions/extension_unittest.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/media_galleries/media_galleries_scan_result_dialog_controller.cc

diff --git a/chrome/browser/media_galleries/media_galleries_scan_result_dialog_controller.cc b/chrome/browser/media_galleries/media_galleries_scan_result_dialog_controller.cc

index f047886d9d329b29edb94896c8f36a3bb220568b..51970c449e41ca7e8080a65c9c02957c37f0131f 100644

--- a/chrome/browser/media_galleries/media_galleries_scan_result_dialog_controller.cc

+++ b/chrome/browser/media_galleries/media_galleries_scan_result_dialog_controller.cc

@@ -121,13 +121,13 @@ base::string16 MediaGalleriesScanResultDialogController::GetSubtext() const {

extensions::MediaGalleriesPermission::CheckParam delete_param(

extensions::MediaGalleriesPermission::kDeletePermission);

bool has_copy_to_permission =

- extensions::PermissionsData::CheckAPIPermissionWithParam(

- extension_, extensions::APIPermission::kMediaGalleries,

- &copy_to_param);

+ extensions::PermissionsData::ForExtension(extension_)

not at google - send to devlin 2014/06/02 23:20:06 here

Devlin 2014/06/03 15:28:21 Done.

+ ->CheckAPIPermissionWithParam(

+ extensions::APIPermission::kMediaGalleries, &copy_to_param);

bool has_delete_permission =

- extensions::PermissionsData::CheckAPIPermissionWithParam(

- extension_, extensions::APIPermission::kMediaGalleries,

- &delete_param);

+ extensions::PermissionsData::ForExtension(extension_)

+ ->CheckAPIPermissionWithParam(

+ extensions::APIPermission::kMediaGalleries, &delete_param);

int id;

if (has_copy_to_permission)