Refactor PermissionsData pt1

chrome/browser/chrome_content_browser_client.cc

Index: chrome/browser/chrome_content_browser_client.cc
diff --git a/chrome/browser/chrome_content_browser_client.cc b/chrome/browser/chrome_content_browser_client.cc
index 269e78ae1c1c9cee8163b407dcf6b4ca7008d005..72b7b880524924f63a08c77682c280b04afb39a2 100644
--- a/chrome/browser/chrome_content_browser_client.cc
+++ b/chrome/browser/chrome_content_browser_client.cc
@@ -2509,14 +2509,14 @@ bool ChromeContentBrowserClient::AllowPepperSocketAPI(
         if (params) {
           extensions::SocketPermission::CheckParam check_params(
               params->type, params->host, params->port);
-          if (extensions::PermissionsData::CheckAPIPermissionWithParam(
-                  extension, extensions::APIPermission::kSocket,
-                  &check_params)) {
+          if (extensions::PermissionsData::ForExtension(extension)
+                  ->CheckAPIPermissionWithParam(
+                      extensions::APIPermission::kSocket, &check_params)) {
             return true;
           }
         } else {
-          if (extensions::PermissionsData::HasAPIPermission(
-                  extension, extensions::APIPermission::kSocket)) {
+          if (extensions::PermissionsData::ForExtension(extension)
+                  ->HasAPIPermission(extensions::APIPermission::kSocket)) {

[not at google - send to devlin, 2014/06/02 23:20:06]

it's true though; one of the advantages of
extensions::PermissionsData::ForExtension(..) is that you can actually hold onto
that PermissionsData. I'll point out places. here is one.

[Devlin, 2014/06/03 15:28:21]

Done.

             return true;
           }
         }