chrome/common/extensions/permissions/settings_override_permission_unittest.cc - Issue 309533007: Refactor PermissionsData pt1

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/common/extensions/permissions/settings_override_permission_unittest.cc

Issue 309533007: Refactor PermissionsData pt1 (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Latest master Created 6 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/common/extensions/permissions/permission_set_unittest.cc ('k') | chrome/renderer/extensions/chrome_extensions_dispatcher_delegate.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/common/extensions/permissions/settings_override_permission_unittest.cc

diff --git a/chrome/common/extensions/permissions/settings_override_permission_unittest.cc b/chrome/common/extensions/permissions/settings_override_permission_unittest.cc

index d5b9a0457dca2fa290d88856cc733fc65f89aa20..54d1774ef4275e461dc9d4d37852cba1f3fcf8b3 100644

--- a/chrome/common/extensions/permissions/settings_override_permission_unittest.cc

+++ b/chrome/common/extensions/permissions/settings_override_permission_unittest.cc

@@ -69,7 +69,7 @@ TEST_F(SettingsOverridePermissionTest, HomePage) {

#if defined(OS_WIN)

EXPECT_TRUE(permission_set->HasAPIPermission(APIPermission::kHomepage));

std::vector<base::string16> warnings =

- PermissionsData::GetPermissionMessageStrings(extension.get());

+ PermissionsData::ForExtension(extension)->GetPermissionMessageStrings();

ASSERT_EQ(1u, warnings.size());

EXPECT_EQ("Change your home page to: google.com/",

base::UTF16ToUTF8(warnings[0]));

@@ -93,7 +93,7 @@ TEST_F(SettingsOverridePermissionTest, StartupPages) {

#if defined(OS_WIN)

EXPECT_TRUE(permission_set->HasAPIPermission(APIPermission::kStartupPages));

std::vector<base::string16> warnings =

- PermissionsData::GetPermissionMessageStrings(extension.get());

+ PermissionsData::ForExtension(extension)->GetPermissionMessageStrings();

ASSERT_EQ(1u, warnings.size());

EXPECT_EQ("Change your start page to: startup.com/startup.html",

base::UTF16ToUTF8(warnings[0]));

@@ -117,7 +117,7 @@ TEST_F(SettingsOverridePermissionTest, SearchSettings) {

#if defined(OS_WIN)

EXPECT_TRUE(permission_set->HasAPIPermission(APIPermission::kSearchProvider));

std::vector<base::string16> warnings =

- PermissionsData::GetPermissionMessageStrings(extension.get());

+ PermissionsData::ForExtension(extension)->GetPermissionMessageStrings();

ASSERT_EQ(1u, warnings.size());

EXPECT_EQ("Change your search settings to: google.com",

base::UTF16ToUTF8(warnings[0]));