chrome/browser/ui/webui/extensions/extension_settings_handler.cc - Issue 309533007: Refactor PermissionsData pt1

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/webui/extensions/extension_settings_handler.cc

Issue 309533007: Refactor PermissionsData pt1 (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Latest master Created 6 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/browser/ui/webui/extensions/extension_settings_handler.cc

diff --git a/chrome/browser/ui/webui/extensions/extension_settings_handler.cc b/chrome/browser/ui/webui/extensions/extension_settings_handler.cc

index ebd2679c6dfacddc120410fb4abaaceb1fa576a2..95110516145ac20b2cc372d53717df3f92762908 100644

--- a/chrome/browser/ui/webui/extensions/extension_settings_handler.cc

+++ b/chrome/browser/ui/webui/extensions/extension_settings_handler.cc

@@ -260,9 +260,9 @@ base::DictionaryValue* ExtensionSettingsHandler::CreateExtensionDetailValue(

// - The feature is enabled.

// - The extension has access to enough urls that we can't just let it run

// on those specified in the permissions.

- bool wants_all_urls =

- FeatureSwitch::scripts_require_action()->IsEnabled() &&

- PermissionsData::RequiresActionForScriptExecution(extension);

+ bool wants_all_urls = FeatureSwitch::scripts_require_action()->IsEnabled() &&

+ PermissionsData::ForExtension(extension)

+ ->RequiresActionForScriptExecution(extension);

extension_data->SetBoolean("wantsAllUrls", wants_all_urls);

extension_data->SetBoolean(

"allowAllUrls",