chrome/browser/media_galleries/media_galleries_scan_result_dialog_controller.cc - Issue 309533007: Refactor PermissionsData pt1

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/media_galleries/media_galleries_scan_result_dialog_controller.cc

Issue 309533007: Refactor PermissionsData pt1 (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Latest master Created 6 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/media_galleries/media_galleries_preferences.cc ('k') | chrome/browser/ui/cocoa/location_bar/location_bar_view_mac.mm » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/media_galleries/media_galleries_scan_result_dialog_controller.cc

diff --git a/chrome/browser/media_galleries/media_galleries_scan_result_dialog_controller.cc b/chrome/browser/media_galleries/media_galleries_scan_result_dialog_controller.cc

index f047886d9d329b29edb94896c8f36a3bb220568b..b5cd3fe826f32b0d233a0e7556d118f45f3cbbe1 100644

--- a/chrome/browser/media_galleries/media_galleries_scan_result_dialog_controller.cc

+++ b/chrome/browser/media_galleries/media_galleries_scan_result_dialog_controller.cc

@@ -120,14 +120,12 @@ base::string16 MediaGalleriesScanResultDialogController::GetSubtext() const {

extensions::MediaGalleriesPermission::kCopyToPermission);

extensions::MediaGalleriesPermission::CheckParam delete_param(

extensions::MediaGalleriesPermission::kDeletePermission);

- bool has_copy_to_permission =

- extensions::PermissionsData::CheckAPIPermissionWithParam(

- extension_, extensions::APIPermission::kMediaGalleries,

- &copy_to_param);

- bool has_delete_permission =

- extensions::PermissionsData::CheckAPIPermissionWithParam(

- extension_, extensions::APIPermission::kMediaGalleries,

- &delete_param);

+ const extensions::PermissionsData* permissions_data =

+ extensions::PermissionsData::ForExtension(extension_);

+ bool has_copy_to_permission = permissions_data->CheckAPIPermissionWithParam(

+ extensions::APIPermission::kMediaGalleries, &copy_to_param);

+ bool has_delete_permission = permissions_data->CheckAPIPermissionWithParam(

+ extensions::APIPermission::kMediaGalleries, &delete_param);

int id;

if (has_copy_to_permission)