chrome/browser/extensions/api/tab_capture/tab_capture_api.cc - Issue 309533007: Refactor PermissionsData pt1

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/extensions/api/tab_capture/tab_capture_api.cc

Issue 309533007: Refactor PermissionsData pt1 (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Latest master Created 6 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/browser/extensions/api/tab_capture/tab_capture_api.cc

diff --git a/chrome/browser/extensions/api/tab_capture/tab_capture_api.cc b/chrome/browser/extensions/api/tab_capture/tab_capture_api.cc

index 1fa909a2905ef3702fcfd926518386b3dab864a2..5967dac3c0791cf2cdf5a438e2bec3b70d060231 100644

--- a/chrome/browser/extensions/api/tab_capture/tab_capture_api.cc

+++ b/chrome/browser/extensions/api/tab_capture/tab_capture_api.cc

@@ -89,8 +89,8 @@ bool TabCaptureCaptureFunction::RunSync() {

// Make sure either we have been granted permission to capture through an

// extension icon click or our extension is whitelisted.

- if (!PermissionsData::HasAPIPermissionForTab(

- extension, tab_id, APIPermission::kTabCaptureForTab) &&

+ if (!PermissionsData::ForExtension(extension)

+ ->HasAPIPermissionForTab(tab_id, APIPermission::kTabCaptureForTab) &&

CommandLine::ForCurrentProcess()->GetSwitchValueASCII(

switches::kWhitelistedExtensionID) != extension_id &&

!SimpleFeature::IsIdInList(