chrome/browser/extensions/api/cookies/cookies_helpers.cc - Issue 309533007: Refactor PermissionsData pt1

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/extensions/api/cookies/cookies_helpers.cc

Issue 309533007: Refactor PermissionsData pt1 (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Latest master Created 6 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/browser/extensions/api/cookies/cookies_helpers.cc

diff --git a/chrome/browser/extensions/api/cookies/cookies_helpers.cc b/chrome/browser/extensions/api/cookies/cookies_helpers.cc

index 7044bfe51111ec1987582c7fb7cc79ec4ef74900..957a337db37a0a0eaf7c5111a9d870894d601f51 100644

--- a/chrome/browser/extensions/api/cookies/cookies_helpers.cc

+++ b/chrome/browser/extensions/api/cookies/cookies_helpers.cc

@@ -136,7 +136,8 @@ void AppendMatchingCookiesToVector(const net::CookieList& all_cookies,

// Ignore any cookie whose domain doesn't match the extension's

// host permissions.

GURL cookie_domain_url = GetURLFromCanonicalCookie(*it);

- if (!PermissionsData::HasHostPermission(extension, cookie_domain_url))

+ if (!PermissionsData::ForExtension(extension)

+ ->HasHostPermission(cookie_domain_url))

continue;

// Filter the cookie using the match filter.

cookies_helpers::MatchFilter filter(details);