Added processing for a lost status to UpdateEngineClient.

Added processing for a lost status to UpdateEngineClient.

BUG=378865
Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=274504

[Daniel Erat, 2014-05-30 22:08:47]

i see switch statements in chrome that examine status values. one even has a
NOTREACHED() in its default section. do you need to update some or all of those
to handle the new value that you're returning here?

chrome/browser/chromeos/login/screens/update_screen.cc
chrome/browser/extensions/api/system_private/system_private_api.cc
chrome/browser/ui/webui/help/version_updater_chromeos.cc
(maybe more; i just grepped for one of the existing values)

please also make sure you've compiled this change -- i thought that we error out
when there are unhandled enum values in switch statements. maybe that just
happens with clang, though (i.e. use the linux_chrome_clang bot).

[merkulova, 2014-06-02 12:57:48]

+dmazzoni@ for system_private_api.cc
+nkostylev@ for version_updater_chromeos.cc and update_screen.cc

You're right, Daniel. Haven't tried to compile it.

[Nikita (slow), 2014-06-02 13:14:12]

lgtm

[Daniel Erat, 2014-06-02 13:41:31]

lgtm if it builds (i started a few tries to check)

https://codereview.chromium.org/309533006/diff/20001/chrome/browser/extension...
File chrome/browser/extensions/api/system_private/system_private_api.cc (right):

https://codereview.chromium.org/309533006/diff/20001/chrome/browser/extension...
chrome/browser/extensions/api/system_private/system_private_api.cc:119: case
chromeos::UpdateEngineClient::UPDATE_STATUS_ATTEMPTING_ROLLBACK:
nit: just combine this with the previous case?

[dmazzoni, 2014-06-02 14:46:17]

lgtm

for system_private

[merkulova, 2014-06-03 06:55:08]

The CQ bit was checked by merkulova@chromium.org

[commit-bot: I haz the power, 2014-06-03 06:55:28]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/merkulova@chromium.org/309533006/40001

[commit-bot: I haz the power, 2014-06-03 08:26:44]

FYI, CQ is re-trying this CL (attempt #1).
The failing builders are:
  android_aosp on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/android_aosp/builds/8...)
  linux_chromium_chromeos_rel on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/linux_chromium_chrome...)

[merkulova, 2014-06-03 09:12:59]

The CQ bit was checked by merkulova@chromium.org

[commit-bot: I haz the power, 2014-06-03 09:13:28]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/merkulova@chromium.org/309533006/60001

[commit-bot: I haz the power, 2014-06-03 11:47:32]

FYI, CQ is re-trying this CL (attempt #1).
The failing builders are:
  android_dbg_triggered_tests on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/android_dbg_triggered...)
  ios_dbg_simulator on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/ios_dbg_simulator/bui...)
  ios_rel_device_ninja on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/ios_rel_device_ninja/...)

[commit-bot: I haz the power, 2014-06-03 13:24:41]

Change committed as 274504