Issue 309523002: Move installation of ContentShell.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 309523002: Move installation of ContentShell. (Closed)

Created:
6 years, 6 months ago by alokp

Modified:
6 years, 6 months ago

Reviewers:
navabi1, navabi

CC:
chromium-reviews, klundberg+watch_chromium.org, bulach+watch_chromium.org, yfriedman+watch_chromium.org, ilevy-cc_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

Move installation of ContentShell. Running bb_device_steps.py with --install option adds an explicit install step and eliminates the need to install it as part of running the test with incorrect label. The install step was currently being grouped into provision_device step. This patch partially relands r273386, which was reverted due to issues with gpu rasterization test. This portion of the patch is merely cleanup that can be landed separately. BUG=368495 TBR=navabi@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=273505

Patch Set 1 #

Created: 6 years, 6 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+7 lines, -6 lines)			Patch
	M	build/android/buildbot/bb_device_steps.py	View		2 chunks	+4 lines, -5 lines	0 comments	Download
	M	build/android/buildbot/bb_run_bot.py	View		1 chunk	+3 lines, -1 line	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

alokp

Committed patchset #1 manually as r273505 (presubmit successful).

6 years, 6 months ago (2014-05-29 16:59:26 UTC) #1

Message was sent while issue was closed.

lgtm

Expand Messages | Collapse Messages