Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1524)

Unified Diff: content/child/service_worker/service_worker_handle_reference.h

Issue 309503014: Make ServiceWorkerDispatcher reuse existing WebServiceWorkerImpls. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Correct comment. Created 6 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/child/service_worker/service_worker_handle_reference.h
diff --git a/content/child/service_worker/service_worker_handle_reference.h b/content/child/service_worker/service_worker_handle_reference.h
index 48f969f669b7f1eafd9243b29f6052ec35877ae5..0393e55aa96c8955dc0e02893bd7f8d837429ce5 100644
--- a/content/child/service_worker/service_worker_handle_reference.h
+++ b/content/child/service_worker/service_worker_handle_reference.h
@@ -17,12 +17,17 @@ class ThreadSafeSender;
// (in the browser side) in ctor and dtor.
class ServiceWorkerHandleReference {
public:
- // Creates a new ServiceWorkerHandleReference (and increments ref-count).
+ // Creates a new ServiceWorkerHandleReference and increments ref-count.
static scoped_ptr<ServiceWorkerHandleReference> Create(
const ServiceWorkerObjectInfo& info,
ThreadSafeSender* sender);
- // This doesn't increment ref-count in ctor.
- static scoped_ptr<ServiceWorkerHandleReference> CreateForDeleter(
+
+ // Creates a new ServiceWorkerHandleReference by adopting a
+ // ref-count. ServiceWorkerHandleReferences created this way must
+ // have a matching
+ // ServiceWorkerDispatcherHost::RegisterServiceWorkerHandle call on
+ // the browser side.
+ static scoped_ptr<ServiceWorkerHandleReference> Adopt(
const ServiceWorkerObjectInfo& info,
ThreadSafeSender* sender);

Powered by Google App Engine
This is Rietveld 408576698