Issue 309503013: Revert 174956 "Oilpan: Move ThreadableWebSocketChannelClientWrap..."

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 309503013: Revert 174956 "Oilpan: Move ThreadableWebSocketChannelClientWrap..." (Closed)

Created:
6 years, 6 months ago by haraken

Modified:
6 years, 6 months ago

Reviewers:
haraken, oilpan-reviews, tkent

CC:
blink-reviews

Base URL:
svn://svn.chromium.org/blink/

Visibility:
Public.

More Reviews

Description

Revert 174956 "Oilpan: Move ThreadableWebSocketChannelClientWrap..." This CL broke worker-reload-repeated.html in oilpan bots. > Oilpan: Move ThreadableWebSocketChannelClientWrapper to Oilpan's heap > > This is a preparation for moving WebSocketChannelClient to the heap. > > This CL adds a template specialization to CrossThreadCopier.h so that ThreadableWebSocketChannelClientWrapper* can be passed to createCallbackTask(). > > BUG=340522 > > Review URL: https://codereview.chromium.org/267323004 TBR=haraken@chromium.org Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=175242

Patch Set 1 #

Created: 6 years, 6 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+76 lines, -108 lines)			Patch
M	trunk/Source/core/dom/CrossThreadTask.h	View	8 chunks	+8 lines, -14 lines	0 comments	Download
M	trunk/Source/modules/websockets/ThreadableWebSocketChannelClientWrapper.h	View	2 chunks	+9 lines, -12 lines	0 comments	Download
M	trunk/Source/modules/websockets/ThreadableWebSocketChannelClientWrapper.cpp	View	2 chunks	+9 lines, -13 lines	0 comments	Download
M	trunk/Source/modules/websockets/WorkerThreadableWebSocketChannel.h	View	7 chunks	+8 lines, -10 lines	0 comments	Download
M	trunk/Source/modules/websockets/WorkerThreadableWebSocketChannel.cpp	View	11 chunks	+18 lines, -24 lines	0 comments	Download
M	trunk/Source/platform/CrossThreadCopier.h	View	6 chunks	+18 lines, -29 lines	0 comments	Download
M	trunk/Source/platform/CrossThreadCopier.cpp	View	2 chunks	+6 lines, -6 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

Message was sent while issue was closed.

lgtm

Expand Messages | Collapse Messages