Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(224)

Unified Diff: sdk/lib/_internal/pub/lib/src/barback/web_socket_api.dart

Issue 309503005: Convert json_rpc.Server to take a Stream and StreamSink. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: code review Created 6 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « pkg/json_rpc_2/test/server/utils.dart ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: sdk/lib/_internal/pub/lib/src/barback/web_socket_api.dart
diff --git a/sdk/lib/_internal/pub/lib/src/barback/web_socket_api.dart b/sdk/lib/_internal/pub/lib/src/barback/web_socket_api.dart
index 7722b942a6ce3aef0a549e6ed6f555c38a25262f..6f729584857aca565d431dbbf0ea70931033ca77 100644
--- a/sdk/lib/_internal/pub/lib/src/barback/web_socket_api.dart
+++ b/sdk/lib/_internal/pub/lib/src/barback/web_socket_api.dart
@@ -23,14 +23,14 @@ import 'asset_environment.dart';
/// This is a [JSON-RPC 2.0](http://www.jsonrpc.org/specification) server. Its
/// methods are described in the method-level documentation below.
class WebSocketApi {
- final CompatibleWebSocket _socket;
final AssetEnvironment _environment;
- final _server = new json_rpc.Server();
+ final json_rpc.Server _server;
/// Whether the application should exit when this connection closes.
bool _exitOnClose = false;
- WebSocketApi(this._socket, this._environment) {
+ WebSocketApi(CompatibleWebSocket socket, this._environment)
+ : _server = new json_rpc.Server(socket) {
_server.registerMethod("urlToAssetId", _urlToAssetId);
_server.registerMethod("pathToUrls", _pathToUrls);
_server.registerMethod("serveDirectory", _serveDirectory);
@@ -51,11 +51,7 @@ class WebSocketApi {
/// complete with an error if the socket had an error, otherwise it will
/// complete to `null`.
Future listen() {
- return _socket.listen((request) {
- _server.parseRequest(request).then((response) {
- if (response != null) _socket.add(response);
- });
- }, cancelOnError: true).asFuture().then((_) {
+ _server.listen().then((_) {
if (!_exitOnClose) return;
log.message("WebSocket connection closed, terminating.");
flushThenExit(exit_codes.SUCCESS);
« no previous file with comments | « pkg/json_rpc_2/test/server/utils.dart ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698