Issue 3095005: add qemu-kvm-0.12.5 ebuild and include in hard-host-depends

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 3095005: add qemu-kvm-0.12.5 ebuild and include in hard-host-depends (Closed)

Created:
10 years, 4 months ago by Olof Johansson

Modified:
9 years, 7 months ago

Reviewers:
Mandeep Singh Baines, rtc, anush

CC:
chromium-os-reviews_chromium.org, Mandeep Singh Baines, tedbo, adlr, anush

Base URL:
ssh://git@gitrw.chromium.org:9222/chromiumos-overlay.git

Visibility:
Public.

Description

add qemu-kvm-0.12.5 ebuild and include in hard-host-depends Disable a bunch of targets that we don't care about, and mask as stable on amd64. Also, don't build any user targets and remove the conflict with qemu-user. Add it to hard-host-depends to make sure it's available for local testing.

Patch Set 1 #

Patch Set 2 : tweaks #

Patch Set 3 : add to hard-host-depends too #

Patch Set 4 : fix hard host depends #

Created: 10 years, 4 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+229 lines, --1 lines)			Patch
A	app-emulation/qemu-kvm/files/qemu-kvm	View		1 chunk	+2 lines, -0 lines	0 comments	Download
A	app-emulation/qemu-kvm/qemu-kvm-0.12.5.ebuild	View	1	1 chunk	+218 lines, -0 lines	0 comments	Download
M	chromeos-base/hard-host-depends/hard-host-depends-0.0.1.ebuild	View	3	1 chunk	+6 lines, -0 lines	0 comments	Download
A +	chromeos-base/hard-host-depends/hard-host-depends-0.0.1-r58.ebuild	View		0 chunks	+-1 lines, --1 lines	0 comments	Download
M	profiles/default/linux/package.use	View		1 chunk	+4 lines, -0 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

rtc

10 years, 4 months ago (2010-08-11 00:39:37 UTC) #2

LGTM

I just tested your changes by running the BVT and everything worked as
expected.

-Ryan

On Mon, Aug 9, 2010 at 3:28 PM, <olofj@chromium.org> wrote:

> Reviewers: rtc,
>
> Description:
> add qemu-kvm-0.12.5 ebuild
>
> Disable a bunch of targets that we don't care about, and mask as stable on
> amd64. Also, don't build any user targets and remove the conflict with
> qemu-user.
>
>
> Please review this at http://codereview.chromium.org/3095005/show
>
> SVN Base: ssh://git@gitrw.chromium.org:9222/chromiumos-overlay.git
>
> Affected files:
>  A app-emulation/qemu-kvm/files/qemu-kvm
>  A app-emulation/qemu-kvm/qemu-kvm-0.12.5.ebuild
>
>
>

Expand Messages | Collapse Messages